Fix d3d12 build. #1249
Merged
Fix d3d12 build. #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put get_address inside.
symbol undef though
|
For some reason some of DH commits slipped in this PR, like: vlj@fd6295c |
|
@danilaml yes, and he explained why in the pull request message |
- Drop smart vertex storage and use OpenGL's one instead.
|
Now use domethod instead of extra function for semaphore release. |
|
Very cool! But you don't need to call domethod, that would be called automatically. I'll fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes d3d12 build.
It does so by replaying DH merge in a more atomic way so that it was easier to track what's happened.
Unfortunatly there are still some regression. Stencil reflect test still doesn't work and switch to opengl style buffer storage led to higher memory usage making Disgaea 3 crashes.
I'm trying to fix these issues in another PR.