Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Tiled memory handling improvements #15160

Merged
merged 10 commits into from Feb 10, 2024
Merged

rsx: Tiled memory handling improvements #15160

merged 10 commits into from Feb 10, 2024

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Feb 6, 2024

A series of improvements targeting tiled memory bugs. Fixes several different issues, but primarily addresses the repeating/tiling mirror effect in some games when partial copies were done on tiled regions.

  • Fixes some broken visuals in NFS Rivals. There's still some garbling at the screen edges that goes away if I upload full tiles to the GPU, but this makes no logical sense and I likely have a bug somewhere else.
  • Fixes broken visuals in Split/Second. More stuff now renders correctly with the downside now being that some glitchy stuff that was invisible before is now visible.

RSX tiling work is still WIP, so I'm committing this as-is before I lose my mind.

See #14682

@legend800
Copy link

legend800 commented Feb 6, 2024

Addresses the stripping issue with some artifacting as you mentioned (sky, around car, side bar, etc.). Also, the effects have regressed - no smoke or explosions at all now (native res). Was working partially before, albeit it with the stripping problem.

2024-02-05 19_57_02-FPS_ 30 01 _ Vulkan _ 0 0 30-90381e60 Alpha _ maint0 _ Split_Second  NPUB30450 2024-02-05 19_58_02-FPS_ 29 96 _ Vulkan _ 0 0 30-90381e60 Alpha _ maint0 _ Split_Second  NPUB30450

RPCS3.log.gz

@Megamouse Megamouse added the RSX label Feb 6, 2024
@kd-11
Copy link
Contributor Author

kd-11 commented Feb 6, 2024

Also, the effects have regressed - no smoke or explosions at all now (native res)

I cannot reproduce this. The effects render fine on my setup.
The only issue I have is the red and green colors on the screen, but those aren't tiled so it's likely caused by something else.

@legend800
Copy link

Checked again and I guess I missed the first explosion. So scratch that comment.

It's just all the artifacting as you can see below. My test level is Downtown Central fyi (Quick Play > Race).

My settings: AF off(fix red outlines), WCB (smearing), RSX tiled memory(tiling), 100% res(fix pixelation), RDB, WDB, RCB

2024-02-06 08_27_42-FPS_ 30 01 _ Vulkan _ 0 0 30-90381e60 Alpha _ maint0 _ Split_Second  NPUB30450 2024-02-06 08_27_18-FPS_ 29 99 _ Vulkan _ 0 0 30-90381e60 Alpha _ maint0 _ Split_Second  NPUB30450 2024-02-06 08_30_21-FPS_ 30 00 _ Vulkan _ 0 0 30-90381e60 Alpha _ maint0 _ Split_Second  NPUB30450

RPCS3.log.gz

@kd-11 kd-11 merged commit 4746ef0 into RPCS3:master Feb 10, 2024
6 checks passed
@Triticum0
Copy link

@kd-11 Just FYI, Mercury Hg is not properly fixed with this pr. https://www.youtube.com/watch?v=YX7CqoSsjpw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants