OpenAL: Fix crash when loading certain audio devices #15660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the OpenAL binary from 1.19.1 to 1.23.1, the headers/libraries were updated in the past but the binary was forgotten in #14642.
This fixes the long standing crash #14502 when opening the settings menu while using one of the affected audio input devices.
The crash was happening when calling alcGetString, inside the OpenAL32.dll binary itself, the msvcrt.dll mention in the crash was because it was crashing inside a string comparison function inside the msvcrt library.
rpcs3/rpcs3/rpcs3qt/microphone_creator.cpp
Line 29 in d9ec33f
Seems to be related to the fact that the device name has double spaces in the name, example from the log:
name=Speakers (XSplit Stream Audio Renderer)
Known offenders:
Tested before/after on a Windows 10 system with the affected XSplit device.