Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAL: Fix crash when loading certain audio devices #15660

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

AniLeo
Copy link
Member

@AniLeo AniLeo commented Jun 5, 2024

Updates the OpenAL binary from 1.19.1 to 1.23.1, the headers/libraries were updated in the past but the binary was forgotten in #14642.

This fixes the long standing crash #14502 when opening the settings menu while using one of the affected audio input devices.

image

The crash was happening when calling alcGetString, inside the OpenAL32.dll binary itself, the msvcrt.dll mention in the crash was because it was crashing inside a string comparison function inside the msvcrt library.

if (const char* devices = alcGetString(nullptr, ALC_CAPTURE_DEVICE_SPECIFIER))

Seems to be related to the fact that the device name has double spaces in the name, example from the log: name=Speakers (XSplit Stream Audio Renderer)

Known offenders:

  • Asus AI Microphone
  • XSplit Stream Audio Renderer

Tested before/after on a Windows 10 system with the affected XSplit device.

Updates the OpenAL binary from 1.19.1 to 1.23.1, the headers/libraries were updated in the past but the binary was forgotten. This fixes RPCS3#14502.
@AniLeo AniLeo merged commit bd85902 into RPCS3:master Jun 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant