Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Add recent games menu #2843

Merged
merged 8 commits into from
Jun 8, 2017
Merged

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Jun 7, 2017

adds a submenu to boot "Boot Recent"

  • submenu contains functions "clear list" and "freeze list"
  • activated "freeze list" will prevent changes to the list
  • successfull boots will be added to the top of the list
  • when the list contains 9 items the last will be removed on new addition
  • every item has a boot shortcut from Ctrl+1 to Ctrl+9
  • games can only be bootet from mainwindow and if emu is not running
  • if names are too long they will be shortened like this "This name is waaa(....)aaaay to long"
  • on mouse hover you will see a tooltip with the full name
  • if the game title is a path it will be shown only as filename while the tooltip remains the path
  • remove invalid paths from list on start or boot

@flash-fire
Copy link
Contributor

Looks pretty good. Only a couple things..

  1. Small nitpick. const QString& instead of const QString& for small efficiency boost of not copying parameters each time.

  2. I haven't thought too hard, but would QActionGroup work better than QLisf<QAction*>?

I think the method layout as is is fine. Makes it fairly close what the code is doing. Though, Neko may disagree with his slightly more agressive stance on lambdas than me.

@twdarkeh
Copy link
Contributor

twdarkeh commented Jun 7, 2017

One request if possible; add a "pin game" to force a single game to stay on the list. Since Disc Games show up on the list, the ability to force them to stay there would be great.

@Megamouse
Copy link
Contributor Author

Megamouse commented Jun 7, 2017

I tried but I don't like the outcome.
maybe in the future (possibly with new Qt Stuff at that point)

You can still use the freeze in the meantime

edit: still trying but I won't resist merge

@AniLeo AniLeo changed the title add recent games menu GUI: Add recent games menu Jun 8, 2017
@AniLeo AniLeo merged commit 6cb7a17 into RPCS3:master Jun 8, 2017
@flash-fire flash-fire deleted the add_boot_last_game branch June 10, 2017 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants