New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsx: Major Fixes #4469
rsx: Major Fixes #4469
Conversation
fixes the remaining part of #3031 |
Fixes #4189 |
rpcs3/Emu/RSX/Common/texture_cache.h
Outdated
const u16 src_w = (const u16)((f32)dst.clip_width / scale_x); | ||
const u16 src_h = (const u16)((f32)dst.clip_height / scale_y); | ||
u16 src_w = (const u16)((f32)dst.clip_width / scale_x); | ||
u16 src_h = (const u16)((f32)dst.clip_height / scale_y); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for the cast to remain const
.
rpcs3/Emu/RSX/rsx_utils.h
Outdated
alpha = false; | ||
} | ||
|
||
inline color4f decode_border_color(u32 colorref) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why it's not static
like the rest?
There's a dark shadow around the character's one in Vulkan: But with OpenGL, crashes before going to main menu (after creating your profile): |
Issue is because vulkan does not support custom border color like opengl. You have to pick from 3 presets. Dont worry too much about it, we'll improve the preset selection code. |
Blocky lighting in Silent Hill 2 (from Silent Hill: HD Collection) on Vulkan. |
I already said not to post more border color issues. You can clearly see the shadow border breaks at the character's feet. |
oops, didn't see that |
rpcs3/Emu/RSX/Common/texture_cache.h
Outdated
m_flush_always_cache[memory_address] = memory_size; | ||
|
||
//Test for invalidated sections from surface cache occupying same address range | ||
auto &overlapped = find_texture_from_range(memory_address, memory_size); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const auto &overlapped
?
Potential fix for the shadow borders has been added. Check if shadow regressions have been fixed. |
Where to download rpcs3 rsx_wip? |
Aww, is shadow border fix for my issue? |
Need opengl RDC (I know it works fine with OGL but vulkan has no notion of a border color) |
RDR - Gets much further into the game now, very impressive |
I think grid would have been better or at least something where the shadow clearly occupied space it shouldn't be. Not sure whats up with R&C3 but there doesnt seem to be any problem with the border (its <1,1,1,1> which will resolve correctly). Probably unrelated to the others but I'm not sure yet. |
Can't compile on ArchLinux:
|
Getting about a 10 fps increase in Unnamed game 5. This is with latest artifact build. Nice job! |
I guess this is better for you kd? Yakuza 4 OGL renderdoc |
Good capture but unfortunately renderdoc wont open it on my system (consumes all available system memory and kills windows). Maybe you can try a simpler scene? As long as memory consumption when loading does not eat more than ~7GB will be fine. |
I went off AMD's website, it says OpenGL 4.1 Support |
I checked i already have crimson 16.2.1. I know my graphic card has opengl 4.1. |
RPCS3 requires OpenGL 4.3. Let's not spam the PR any further. |
https://community.amd.com/message/2858634. |
Experiences out of memory issue in D3 even when there is enough vram and ram on Nvidia gtx 1060 and 24 Gb ram |
If using vulkan on D3 try cpu blit + wcb - theres some stuff I disabled in there and only fixed properly on opengl for now. |
Vulkan blocky shadow fixed! |
Open tickets for any regressions. Follow-up patches should be available in the next few days. |
This is marked as closed and merged to master. But I can´t find the build ¿? the last build merged is #4422 3 days ago |
@LuismaSP89 this commit was merged ~2hrs ago, have some patience. Every message sent here dings every dev subscribed to this topic. your question is related to builds and their speed/schedule, not this particular commit so it doesn't really fit here. Please use the forums for questions/comments that aren't related directly to testing/debugging the commit. |
@Relsig I only wanted to help and report a possible problem with the builds since normally takes only a few minutes between the merge and the download link in the "downloads" section. And I know what's the use of this commit section, I'm not a rookie in this. |
@LuismaSP89 Im glad you're paying attention to any situations that might
arise, however, the build passed on appveyor and Travis ci. If there was an
issue it wasn't related to this commit directly and the forums are a much
more appropriate place for a discussion about issues with the site.
If you would like to continue this discussion I would like to request that
you open a topic on the forum and mention me. My username is the same.
…On Wed, Apr 25, 2018, 3:20 PM LuismaSP89 ***@***.***> wrote:
@Relsig <https://github.com/Relsig> I only wanted to help and report a
possible problem with the builds since normally takes only a few minutes
between the merge and the download link in the "downloads" section. And I
know what's the use of this commit section, I'm not a rookie in this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4469 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHuKYoJS-dC5ZgOq_OjwS1X43rfZGMbDks5tsNqMgaJpZM4TebhA>
.
On Wed, Apr 25, 2018, 3:20 PM LuismaSP89 ***@***.***> wrote:
@Relsig <https://github.com/Relsig> I only wanted to help and report a
possible problem with the builds since normally takes only a few minutes
between the merge and the download link in the "downloads" section. And I
know what's the use of this commit section, I'm not a rookie in this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4469 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHuKYoJS-dC5ZgOq_OjwS1X43rfZGMbDks5tsNqMgaJpZM4TebhA>
.
|
i am getting Occlusion Overflow with Infamous E {rsx::thread} RSX: Occlusion pool overflow x33295 |
Wipeout seems a bit more playable after the last release, I can actually get about 20fps ingame, without graphic issues |
Hi, GOW 2 HD just run worse, after this ver it runs at 40, 60+ FPS. |
Do not spam a closed PR. Why did you post that @FlatDudeInVR? Are you blaming this PR for that crash? If you are certain it's a regression, you can file a Git Issue as instructed and not comment in a 'merged' PR. To be certain you need to test the build right before the merge and then the build with this PR merged and confirm it does not crash here in the previous build and you can reproduce it easily on the PR build. |
Contains several major improvements
Other