-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf fixes #4631
Perf fixes #4631
Conversation
SOULCALIBUR V, METALGEAR RASING WORKING AGAIN, ALTHOUGH THE PERFORMANCE LOWER TOO IN THE FPS, IN THIS PR, GREETINGS AND GREAT JOB MY SPECIFICATIONS |
Performance is abysmal on Persona 5 with i5 4670K for me. Video intro @ 5 FPS, menu @ 10/15 FPS, before i was fullspeed. Tales of vesperia also: 2 FPS. |
P5 is not as bad as @Illynir but is way slower on a x5650 before menu was almost 60fps now its between 30/40 and audio is just cutting |
i5 2500k, worse perf and there are some big stutters too. |
he will correct that. |
This should decrease contention by avoiding global lock
// RawSPU LS | ||
for (u32 i = 0; i < 6; i++) | ||
{ | ||
utils::memory_commit(g_reservations + addr / 16 + i * 0x10000, 0x4000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it needs hw testing, checking if making a reservation is allowed on raw spu ls can be done with sys_process_is_spu_lock_line_reservation_address syscall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, there are only 5 raw spus at max (limitation of sys_spu_initialize)
Performance is back to normal with the last commit. (72574b1) |
I still have some big stutters up to 4/5 seconds |
Is that possible to make test build with this PR rolled back for now? |
It's not that simple, It's a relatively old PR, a lot of extra code was added since May. Rolling back these changes would probably break a lot of stuff. |
@elad335 I tried last test build with that PR: FPS got higher, but it didn't help with freezes introduced right with this PR. And it seems it completely broke "SPU Threads" option on Win 7 and the emulator always uses maximum value. |
No description provided.