Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf fixes #4631

Merged
merged 2 commits into from
May 22, 2018
Merged

Perf fixes #4631

merged 2 commits into from
May 22, 2018

Conversation

Nekotekina
Copy link
Member

No description provided.

@darkdragonz12
Copy link

SOULCALIBUR V, METALGEAR RASING WORKING AGAIN, ALTHOUGH THE PERFORMANCE LOWER TOO IN THE FPS, IN THIS PR, GREETINGS AND GREAT JOB

MY SPECIFICATIONS
INTEL CORE I5, 7400 7 GENERATION
NVIDIA GTX 1050 TI
8 GB RAM DDR4 A 2666MHZ

@Illynir
Copy link

Illynir commented May 21, 2018

Performance is abysmal on Persona 5 with i5 4670K for me.

Video intro @ 5 FPS, menu @ 10/15 FPS, before i was fullspeed.

Tales of vesperia also: 2 FPS.

@spyropt
Copy link

spyropt commented May 21, 2018

P5 is not as bad as @Illynir but is way slower on a x5650 before menu was almost 60fps now its between 30/40 and audio is just cutting

@Ellimosudja
Copy link

i5 2500k, worse perf and there are some big stutters too.

@Luffykun007
Copy link

he will correct that.

This should decrease contention by avoiding global lock
// RawSPU LS
for (u32 i = 0; i < 6; i++)
{
utils::memory_commit(g_reservations + addr / 16 + i * 0x10000, 0x4000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs hw testing, checking if making a reservation is allowed on raw spu ls can be done with sys_process_is_spu_lock_line_reservation_address syscall.

Copy link
Contributor

@elad335 elad335 May 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, there are only 5 raw spus at max (limitation of sys_spu_initialize)

@Illynir
Copy link

Illynir commented May 21, 2018

Performance is back to normal with the last commit. (72574b1)

@jobs-git
Copy link

jobs-git commented May 21, 2018

Using this pull request combined with master c966981 + #4611 + #4592 I was able finish BLUS31437 on my friend's pc.

diablo3_done

In game shows premonition cinematic that only appears after finishing the campaign.

@Nekotekina Nekotekina merged commit 72574b1 into RPCS3:master May 22, 2018
@Ellimosudja
Copy link

I still have some big stutters up to 4/5 seconds

@Psycho-A
Copy link

Is that possible to make test build with this PR rolled back for now?
It's probably broke Windows 7 performance of all subsequent builds and it still didn't return back. SPU freezes emulation for several seconds on almost each game, that Ellimosudja exactly wrote above too...

@RainbowCookie32
Copy link
Contributor

RainbowCookie32 commented Dec 31, 2018

Is that possible to make test build with this PR rolled back for now?
It's probably broke Windows 7 performance of all subsequent builds and it still didn't return back. SPU freezes emulation for several seconds on almost each game, that Ellimosudja exactly wrote above too...

It's not that simple, It's a relatively old PR, a lot of extra code was added since May. Rolling back these changes would probably break a lot of stuff.
Edit: You can go to the archive and download the build before this PR was merged, that's the best thing that comes to my mind

@elad335
Copy link
Contributor

elad335 commented Dec 31, 2018

@Psycho-A you may want to try #5435 if you have a non-tsx cpu.

@Psycho-A
Copy link

@elad335 I tried last test build with that PR: FPS got higher, but it didn't help with freezes introduced right with this PR. And it seems it completely broke "SPU Threads" option on Win 7 and the emulator always uses maximum value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants