GDB server: support for local socket file #4686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad.lock() some personal notes: * possibly select_thread bug? * seems to happen whenever the debugger is attached when the RPCS3 engine is not yet booted, i.e. at program launchtime * seems to break launching games as well
…ode/line number in gdbDebugServer fail message
…or unlinking socket file on termination
Nekotekina
reviewed
Jun 1, 2018
| @@ -3,6 +3,7 @@ | |||
| #include "VFS.h" | |||
| #include "Utilities/Atomic.h" | |||
| #include "Utilities/Config.h" | |||
| #include <sys/socket.h> | |||
There was a problem hiding this comment.
Get it somewhere out of there
Nekotekina
reviewed
Jun 1, 2018
| cfg::string socket_type{this, "Socket type", "INET"}; | ||
| cfg::_int<1, 65535> ipv4_port{this, "IPv4 port", 2345}; | ||
| cfg::string unix_fpath{this, "UNIX socket file path", | ||
| #ifndef _WIN32 |
There was a problem hiding this comment.
Makes more sense to hide the whole config string
There was a problem hiding this comment.
Clarify what you mean?
There was a problem hiding this comment.
he means remove the option completely on windows
|
Needs a rebase with fixing conflicts and handling code reviews |
|
Closing as it's now implemented in a very different manner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: not ready for merge; requires:
-- especially testing local sockets in Windows, currently disabled
-- in addition, this modifies the config yaml (read below)
Right now, the GDB server only listens on an IPv4 port, but it might make sense to include the option to listen at a local socket. May be preferable to a IPv4 since a user won't have to specify special firewall rules.
Note that this also requires how config.yml encodes the GDB server settings; for now, they're in a separate heading, e.g.
whereas RPCS3 just has a single key/value for IPv4 port in the yaml under misc: