rsx: Program Fixes #4844

kd-11 · 2018-07-02T16:59:19Z

Details

Fix nv308a::color implementation
Vertex program decompiler : Fix branch target extraction
Vertex program decompiler : Fix double destination writes
Vertex program decompiler : More human-readable code generated from masked writes
Vertex program analyser rewritten [WIP]
Silence unnecessary log spam (RSX: Depth texture bound to pipeline with unexpected format 0x94 #4398)

Results

Fixes GL/Vulkan: Afro Samurai / Broken graphic #3323
Largely reduces number of generated shaders in some titles with infinite compilation. Corner cases exist so some titles still try to generate new shaders but they are actually false positives (they are not actually saved to the cache at all). This will be fixed before merge.

~~NOTE: Contains the patch from #4830. This is not a replacement - the patch will be removed before merging. It makes testing some titles easier if they are unstable on master.~~

spyropt · 2018-07-02T17:25:32Z

god of war collection II

E {rsx::thread} RSX: shaders_cache: vertex program has more than 32 jump addresses. Entry not saved to cache
RPCS3.log.gz

Emulator-Team-2 · 2018-07-02T17:31:41Z

Edit: Fixed

Regression in Dragon Ball Z: Burst Limit.

Log:
RPCS3.log.gz

kd-11 · 2018-07-02T18:21:16Z

@spyropt the error does not directly affect graphics, so something else is seemingly wrong. Attach rrc capture. Also check the other games in the collection - they should render correctly from my testing (I dont have sparta unfortunately)

kd-11 · 2018-07-02T18:22:01Z

Same goes for the dbz regression. Provide RRC capture as well.

Emulator-Team-2 · 2018-07-02T18:27:55Z

RRC capture:
Dragon Ball Z: Burst Limit
capture.zip

MSuih · 2018-07-02T18:36:13Z

X-Men Origins: Wolverine and THPS HD have regressed, emulator freezes and memory usage climbs to 10+ GB as soon as main menu is reached. Didn't see anything out of ordinary in logs but I'll attach one regardless. This might affect other titles as well but I don't have any more time for testing tonight.
RPCS3.log.gz

bubbavox · 2018-07-02T18:51:19Z

Tested Demon's Souls a little with SPU LLVM.... Played for ~30 min; no crashes. I didn't experiment too much with different settings. Performance was improved from 6718 in Boletarian Palace entrance (usually one of the worst areas), but Penetrator Archstone area was very stuttery. Identical experience with Neko's latest PR #4816 . kd-11's previous PR "praise miyazaki" froze at loading screen.

i5-3570K @ 4.5 // GTX 660 SLI (2)

spyropt · 2018-07-02T19:03:08Z

@kd-11 from my tests it's just ghost of sparta
capture.zip

Kravickas · 2018-07-02T19:30:55Z

Watch Dogs first time ingame

Xcedf · 2018-07-02T21:41:47Z

Resistance 2 regression #4711 fixed on this PR
game has some major graphical issues yet unlike Resistance 1 Demo the things happening on screen are understandable

theoldsport · 2018-07-02T21:42:01Z

Unfortunately the texture flicker and infinite shader generation is still present in Condemned 2

Xcedf · 2018-07-02T22:06:55Z

Seems also fixes texture flickering and caused by that enormous amount of shader cache in GoW 3 Demo

raveskirza · 2018-07-03T02:51:34Z

Beyond2souls: After selecting new game from Menu, the emulator consumes all the system virtual memory and freezes the system. Sometimes the system recovers, other times have to hard restart.
·F 0:04:30.630078 {rsx::thread} class std::bad_alloc thrown: bad allocation
Attached log
RPCS3.zip

EDIT: Fixed in latest commit

ScorchEmber256 · 2018-07-03T02:51:55Z

Fixes #4827, Ratchet and Clank: A Crack In Time now proceeds ingame however crashes after a few minutes of gameplay from #3387

log: RPCS3.zip

legend800 · 2018-07-03T03:44:47Z

Bad news first - Conan BLES00076 has missing ingame gfx. Previously it had bad/missing coloring to the textures but now the whole screen is white.

But the good news (really fantastic news) is that TMNT Reshelled finally has working textures!

Before:

After:

The only issue that remains is missing effects - Krang's eye lasers, Stockman's goo gun, foot soldier death explosions, fire hydrant's water, etc. These are missing on master as well. The real strange thing here (hopefully a clue) is that the effects CAN show sometimes. Example: Level 1: no effects, after hitting exploding barrel, partial effects are shown to end of level. Level 2: No effects, after hitting fire hydrant, FULL effects are shown for the rest of level. Weird.

Xcedf · 2018-07-03T04:05:55Z

Yakuza 3, same issue as Ghost of Sparta above

E {rsx::thread} RSX: shaders_cache: vertex program has more than 32 jump addresses. Entry not saved to cache

Xcedf · 2018-07-03T04:34:49Z

On this PR Sonic Unleashed ingame for me for the first time, don't get stuck on shader ccompile

isshininu · 2018-07-03T06:58:47Z

Silent Hill Downpour so broken on this build i need to use my power button in order to exit rpcs3

RPCS3.zip

MarioSonic2987 · 2018-07-03T07:14:23Z

Sonic Generations Demo goes further. It goes until title screen:

Before:

After:

kd-11 · 2018-07-03T10:54:33Z

A bunch of regressions and problems should be fixed now. Retest.

NeoSlyde

Improves Sonic Unleashed !
I approve !

Emulator-Team-2 · 2018-07-03T11:49:19Z

@kd-11
Regression in Yakuza 3 is fixed in the latest commit.
No change in Dragon Ball Z: Burst Limit.

New RRC capture:
Dragon Ball Z: Burst Limit
Loading screen:
capture.zip

isJuhn · 2018-07-03T12:44:47Z

Latest commit cc8ab13a7f38d03ffeadc620355eb8f1a5638489 makes R&C ACiT crash my driver on going ingame, without that commit, I can play the game pretty well.

stride21 · 2018-07-03T12:52:25Z

Resistance 3 no longer crashes with an error message, now it gets an infinite loop and then crashes without error message.

MarioSonic2987 · 2018-07-03T13:41:22Z

God of War: Ghost of Sparta regression is fixed.

kd-11 · 2018-07-03T13:57:06Z

For the non-graphical bugs where emulator hangs or misbehaves, enable "log shader programs" debug option and attach vp_analyser.bin from your shaderlog folder so I can inspect the contents directly.

legend800 · 2018-07-03T15:31:20Z

Can't get ingame with Conan now on latest commit (previously white screen). Crashes the emu (no log) as soon as I try to load into gameplay now (using Vulkan, default settings).

E {rsx::thread} RSX: Inadequate buffer length submitted for a compute operation.Required=42467328 bytes, Available=33554432 bytes x2 E {rsx::thread} RSX: Blit request denied because the source region does not fit!

isJuhn · 2018-07-03T15:34:21Z

ACiT driver crash as of latest commit
vp_analyser
log

- Fix double destination writes on conditional write masking - Fix codegen to simplify simple scalar comparisons vs vector functions

marosis · 2018-07-06T16:47:50Z

I must say: this emulator is epic. Great work👍

Kravickas · 2018-07-06T17:04:32Z

Last commit is using v5 spu cache from neko merged pr, so be cautious with regression reports

AniLeo · 2018-07-06T17:48:09Z

@Emulator-Team-2 Thanks for reporting

jon-reid · 2018-07-06T18:26:41Z

Had a video driver crash with 26c5661

RDR:GOTY win10, nvidia 6600k, tsx enabled

{rsx::thread} class std::runtime_error thrown: Assertion Failed! Vulkan API call failed with unrecoverable error: Device lost (Driver crashed with unspecified error or stopped responding and recovered) (VK_ERROR_DEVICE_LOST)
(in file c:\projects\rpcs3\rpcs3\emu\rsx\vk\VKHelpers.h:1083)

RPCS3.log.gz

Event log was unsurprisingly useless:

Display driver nvlddmkm stopped responding and has successfully recovered.

kd-11 · 2018-07-06T20:40:36Z

Usually triggered by infinite loop in shaders. Not sure what to do about those since the games are intentionally doing this and most of the time there is extra runtime information to consider. They can be easily detected though; maybe a recursion watcher can be added to abort if the program loops over one condition more than a set number of tries.

legend800 · 2018-07-07T23:51:26Z

@Crispy81 "used to work way back". Why are you spamming this PR with random, unrelated regressions? Don't do that again. Go follow the instructions and write up a proper defect for regressions.

Zangetsu38 · 2018-07-12T23:05:42Z

This Pr have fixed finnaly Bleach ingame

robsoncs10

gabriel

Javix5 · 2019-12-03T21:00:12Z

I've got a i5 7400 and GTX 1060 6 gb. Sonic Unleashed is possible play it? I tried but min 3fps max 23 fps at gameplay. I know it's Ingame. I hope when it'll be playable, my cpu can support it

RainbowCookie32 · 2019-12-03T21:03:02Z

Don't spam random pull requests with this, go to our Discord server instead: https://discord.me/RPCS3

Emulator-Team-2 mentioned this pull request Jul 2, 2018

GL/Vulkan: Afro Samurai / Broken graphic #3323

Closed

bubbavox mentioned this pull request Jul 2, 2018

SPU LLVM WIP #4816

Merged

NeoSlyde approved these changes Jul 3, 2018

View reviewed changes

kd-11 added 4 commits July 6, 2018 19:35

rsx/vp: Discard broken vertex programs with no writes to POS register

a5b4314

rsx/vp: CodeGen improvements

7cfeb62

- Fix double destination writes on conditional write masking - Fix codegen to simplify simple scalar comparisons vs vector functions

rsx: Silence harmless warning

142661b

rsx/Qt: Fix Qt shader loading dialog crash

26c5661

kd-11 force-pushed the rsx_volatile branch from 926150b to 26c5661 Compare July 6, 2018 16:36

RPCS3 deleted a comment from allens39 Jul 6, 2018

RPCS3 deleted a comment from Emulator-Team-2 Jul 6, 2018

RPCS3 deleted a comment from allens39 Jul 6, 2018

AniLeo mentioned this pull request Jul 6, 2018

Tiger Woods 14 stuck on intro with huge log file #4853

Closed

kd-11 changed the title ~~[WIP] rsx: Program Fixes~~ rsx: Program Fixes Jul 7, 2018

Merge branch 'master' into rsx_volatile

045ecf8

kd-11 merged commit f0a9799 into RPCS3:master Jul 7, 2018

isJuhn mentioned this pull request Jul 7, 2018

Insomniac engine v3 & v4 fatal error upon going ingame #4827

Closed

This was referenced Jul 7, 2018

RSX: Depth texture bound to pipeline with unexpected format 0x94 #4398

Closed

Resistance 2 regression #4711

Closed

Missing Textures/ Reflections in TMNT Turtles in Time RESHELLED #3807

Closed

Finoderi mentioned this pull request Jul 15, 2018

Demon's Souls hangs with verification problem error #4887

Closed

robsoncs10 reviewed Sep 19, 2018

View reviewed changes

RPCS3 deleted a comment from ixDossRi Nov 12, 2020

RPCS3 deleted a comment Jan 8, 2022

RPCS3 locked as spam and limited conversation to collaborators Jan 8, 2022

rsx: Program Fixes #4844

rsx: Program Fixes #4844

Conversation

kd-11 commented Jul 2, 2018 • edited Loading

spyropt commented Jul 2, 2018

Emulator-Team-2 commented Jul 2, 2018 • edited Loading

kd-11 commented Jul 2, 2018

kd-11 commented Jul 2, 2018

Emulator-Team-2 commented Jul 2, 2018

MSuih commented Jul 2, 2018 • edited Loading

bubbavox commented Jul 2, 2018 • edited Loading

spyropt commented Jul 2, 2018

Kravickas commented Jul 2, 2018 • edited Loading

Xcedf commented Jul 2, 2018

theoldsport commented Jul 2, 2018 • edited Loading

Xcedf commented Jul 2, 2018

raveskirza commented Jul 3, 2018 • edited Loading

ScorchEmber256 commented Jul 3, 2018 • edited Loading

legend800 commented Jul 3, 2018 • edited Loading

Xcedf commented Jul 3, 2018

Xcedf commented Jul 3, 2018

isshininu commented Jul 3, 2018

MarioSonic2987 commented Jul 3, 2018

kd-11 commented Jul 3, 2018

NeoSlyde left a comment

Choose a reason for hiding this comment

Emulator-Team-2 commented Jul 3, 2018 • edited Loading

isJuhn commented Jul 3, 2018

stride21 commented Jul 3, 2018

MarioSonic2987 commented Jul 3, 2018

kd-11 commented Jul 3, 2018

legend800 commented Jul 3, 2018

isJuhn commented Jul 3, 2018

marosis commented Jul 6, 2018

Kravickas commented Jul 6, 2018

AniLeo commented Jul 6, 2018

jon-reid commented Jul 6, 2018 • edited Loading

kd-11 commented Jul 6, 2018

legend800 commented Jul 7, 2018

Zangetsu38 commented Jul 12, 2018 • edited Loading

robsoncs10 left a comment

Choose a reason for hiding this comment

Javix5 commented Dec 3, 2019

RainbowCookie32 commented Dec 3, 2019

kd-11 commented Jul 2, 2018 •

edited

Loading

Emulator-Team-2 commented Jul 2, 2018 •

edited

Loading

MSuih commented Jul 2, 2018 •

edited

Loading

bubbavox commented Jul 2, 2018 •

edited

Loading

Kravickas commented Jul 2, 2018 •

edited

Loading

theoldsport commented Jul 2, 2018 •

edited

Loading

raveskirza commented Jul 3, 2018 •

edited

Loading

ScorchEmber256 commented Jul 3, 2018 •

edited

Loading

legend800 commented Jul 3, 2018 •

edited

Loading

Emulator-Team-2 commented Jul 3, 2018 •

edited

Loading

jon-reid commented Jul 6, 2018 •

edited

Loading

Zangetsu38 commented Jul 12, 2018 •

edited

Loading