rsx: Reduce capture size + image_in fixes #5381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
force-pushed
the
experimental
branch
2 times, most recently
from
bee4926
to
c43273f
Compare
|
Will edit with findings as they go along Surf's Up loadable -> ingame Everything else I've reported has either been fixed or suffers from other errors. As far as I can tell, image_in errors seem fixed. |
elad335
force-pushed
the
experimental
branch
2 times, most recently
from
e46ebb6
to
de5c311
Compare
kd-11
reviewed
Dec 2, 2018
kd-11
reviewed
Dec 2, 2018
kd-11
reviewed
Dec 2, 2018
| @@ -900,7 +900,7 @@ namespace rsx | |||
| u8* pixels_dst = vm::_ptr<u8>(get_address(dst_offset + out_offset, dst_dma)); | |||
|
|
|||
| const auto read_address = get_address(src_offset, src_dma); | |||
| rsx->read_barrier(read_address, in_pitch * in_h); | |||
| rsx->read_barrier(read_address, in_pitch * (in_h - 1) + (in_w * in_bpp)); | |||
kd-11
reviewed
Dec 2, 2018
|
|
elad335
force-pushed
the
experimental
branch
2 times, most recently
from
914c4c8
to
c2f9e27
Compare
kd-11
reviewed
Dec 3, 2018
elad335
force-pushed
the
experimental
branch
2 times, most recently
from
93834ad
to
98f97f0
Compare
|
The huge amount of "RSX: NV3089_IMAGE_IN: Invalid dimensions or scaling factor." that exists on Macross 30 vanished. Other problems remains on the game, but this message has gone. |
kd-11
approved these changes
Dec 3, 2018
elad335
force-pushed
the
experimental
branch
3 times, most recently
from
8ec8fe8
to
23cac69
Compare
* Dont bother capturing 'destination' blocks with no data. instead premap all main memory to ensure allocated * Capture zcull and tile state as their compressed gcm forms * Fix index array capturing, ignore empty sets * hle gcm: Fix byteswaping in cellGcmSetZcull
If clip region is empty, dont execute
The hw doesnt fix pitch, when specifying src pitch 0 it copies the same pixels line to dst. keep in mind out_pitch = 0 is not allowed in image_in. Same goes for buffer_notify, though it allows out_pitch to be 0.
extracted from vsh
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g when src pitch is 0, the same line is copied to the destination.
testcase used
original texture.
result using image_in with zero src pitch.
result using buffer_notify with zero dst pitch;
result using buffer_notify with zero src pitch.