My Fixups #5697

elad335 · 2019-03-02T09:57:43Z

Adjust _sys_lwcond_wait mutex unlock to the new unlocking method (only the first unlock flag is used there), logging fixes.
Allow the usage of X8R8G8B8 in source format of rsx::image_in. fixes a regresssion from rsx: Reduce capture size + image_in fixes #5381 (Battle Fantasia [NPUB30126] crashes with unknown_src_color_format #5510)
todo: hw testing testing shows imgae_in supports more source formats than r5g6b6 and a8r8g8b8 at core.
Alpha is always ignored.
Yield ppu thread in ShowSaveDataDialog to allow applications to continue execution in the background. Fixes thread_ctrl::wait_for behaviour #4031 (todo: Investiage similar situations with vsh as well)
make RSXIOMem volatile, minor optimization to avoid double checking address returned.
Fix potential deadlock when waiting for a zcull flush request to clear. (Vulkan)
Fix sync bug in sys_event_flag_set regarding atomic op on event flags.
Fix shared memory page flags. fixes [Regression] Gran Turismo 5 access violation #5707

Hasster1 · 2019-03-02T11:10:13Z

Epic! With this pr, "Transformers: The Game" is now properly saving and loading games, without that black screen.
GTA: SA should be fixed too, 'cause they both were having same problems with black screen after loading.

MsDarkLow · 2019-03-02T15:51:19Z

Yakuza Ishin no longer needs Disable ZCull Occlusion Queries.
Fixes the crashes related to zcull.

uaqlover · 2019-03-02T22:16:45Z

amazing pr elad

but still not working

Cars: Mater-National [BLES00162]

doesn't make save file at all

Cars: Race-O-Rama [BLES00620]

game freeze at making new save or loading save file

thanks again for your hard work

RainbowCookie32 · 2019-03-02T22:26:20Z

With this PR, [PROTOTYPE]™ [NPUB30389] no longer crashes when starting a new game. It freezes randomly after creating the save now, but it seems like it might be a race condition, since it doesn't freeze consistently at the same spot always.

RPCS3.log.gz

elad335 · 2019-03-03T07:22:16Z

@RainbowCookie32 I know Prototype 2 stability is fixed by #5346, so I've created a build with this pr and that pr to check if the cause of the instability is related to that.

toccata10 · 2019-03-03T08:15:50Z

I confirm that Battle Fantasia is playable again (linux, r9 fury, vulkan), which is great.
Thanks for all your fixes, elad335.

RainbowCookie32 · 2019-03-03T16:02:03Z

@RainbowCookie32 I know Prototype 2 stability is fixed by #5346, so I've created a build with this pr and that pr to check if the cause of the instability is related to that.

Froze here with this build, the furthest I've got so far so it looks like Prototype also benefits with that PR's changes.

RPCS3.log.gz

elad335 · 2019-03-03T16:42:18Z

@RainbowCookie32 So it's better than on master? I'm trying to figure out if its a regression from this pr or just a stability issue in general.

RainbowCookie32 · 2019-03-03T16:44:49Z

@RainbowCookie32 So it's better than on master? I'm trying to figure out if its a regression from this pr or just a stability issue in general.

Yep, that build is better than master. I don't think it's a regression on this PR.
Update: Got ingame with that build, seems like it might be just a stability issue in master

sys_lwcond_wait unlocks always with the 'usual' unlocking flags

- Make RSXIOMem volatile. - Hint the compiler to check only once the address returned.

Block adding additional flush requests until the first ones are treated (by adding missing lock)

- From RE, only protocols SYS_SYNC_FIFO and SYS_SYNC_PRIORITY are valid - Use conditional atomic op store in a few places - Properly revert changes in sys_event_flag_set when aomic op fails

Xcedf · 2019-03-08T09:51:12Z

Confirm #5707 fixed here, thanks

TODO: From hw testing, it seems like sys_memory_get_page_attribute and sys_rsx_context_iomap check page size a little differently get_page_attribute() always go by area flags, sys_rsx_context_iomap checks page by the page granularity This means that if the area page size 64k, but shared memory is mapped with SYS_MEMORY_GRANULARITY_1M It can be mapped for rsxio, but the page attribute will indicate 64k page size :thonk: rsxio memory is verified to need 1m pages.

kd-11 · 2019-03-08T16:15:32Z

rpcs3/Emu/Cell/Modules/cellSaveData.cpp

@@ -373,9 +374,15 @@ static NEVER_INLINE error_code savedata_op(ppu_thread& ppu, u32 operation, u32 v

 		while (funcList)
 		{
+			// Yield
+			lv2_obj::sleep(ppu);


🤦‍♂️ Thanks

kd-11

RSX-relevant code is ok

elad335 mentioned this pull request Mar 2, 2019

Cars: Race-O-Rama - Cannot load game saves #5458

Closed

AniLeo requested a review from kd-11 March 2, 2019 20:37

elad335 force-pushed the fixup branch 3 times, most recently from f328109 to a6edd9e Compare March 5, 2019 19:21

elad335 changed the title ~~My Fixup~~ My Fixups Mar 8, 2019

elad335 added 7 commits March 8, 2019 11:23

sys_lwmutex fixup after RPCS3#5680

711cbd1

sys_lwcond_wait unlocks always with the 'usual' unlocking flags

Treat X8R8G8B8 format as A8R8G8B8 in image_in, Fixes RPCS3#5510

f999864

Release ppu thread before ShowSaveDataDialog, Fixes RPCS3#4031

3b61646

Correctness fix for RSXIOMem

18ba0cb

- Make RSXIOMem volatile. - Hint the compiler to check only once the address returned.

vulkan zcull: Fix deadlock in zcull flush waiting

fccc482

Block adding additional flush requests until the first ones are treated (by adding missing lock)

Small improvements to sys_event_flag

158a004

- From RE, only protocols SYS_SYNC_FIFO and SYS_SYNC_PRIORITY are valid - Use conditional atomic op store in a few places - Properly revert changes in sys_event_flag_set when aomic op fails

Use error_code in sys_rsx

a50edb4

elad335 force-pushed the fixup branch from a6edd9e to 7ebdfb1 Compare March 8, 2019 09:27

elad335 mentioned this pull request Mar 8, 2019

[Regression] Gran Turismo 5 access violation #5707

Closed

elad335 force-pushed the fixup branch from 7ebdfb1 to f202ec4 Compare March 8, 2019 09:31

elad335 force-pushed the fixup branch from f202ec4 to 37267a5 Compare March 8, 2019 10:00

elad335 force-pushed the fixup branch from 37267a5 to d829fcd Compare March 8, 2019 11:07

kd-11 reviewed Mar 8, 2019

View reviewed changes

kd-11 approved these changes Mar 8, 2019

View reviewed changes

Merge branch 'master' into fixup

84830a8

Nekotekina merged commit a43e7c1 into RPCS3:master Mar 8, 2019

MsDarkLow mentioned this pull request Mar 8, 2019

Yakuza Games bugs #4489

Open

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

My Fixups #5697

My Fixups #5697

elad335 commented Mar 2, 2019 •

edited

Loading

Hasster1 commented Mar 2, 2019

MsDarkLow commented Mar 2, 2019

uaqlover commented Mar 2, 2019

RainbowCookie32 commented Mar 2, 2019 •

edited

Loading

elad335 commented Mar 3, 2019 •

edited

Loading

toccata10 commented Mar 3, 2019

RainbowCookie32 commented Mar 3, 2019 •

edited

Loading

elad335 commented Mar 3, 2019

RainbowCookie32 commented Mar 3, 2019 •

edited

Loading

Xcedf commented Mar 8, 2019

kd-11 Mar 8, 2019

kd-11 left a comment

This comment has been minimized.

This comment has been minimized.

My Fixups #5697

My Fixups #5697

Conversation

elad335 commented Mar 2, 2019 • edited Loading

Hasster1 commented Mar 2, 2019

MsDarkLow commented Mar 2, 2019

uaqlover commented Mar 2, 2019

RainbowCookie32 commented Mar 2, 2019 • edited Loading

elad335 commented Mar 3, 2019 • edited Loading

toccata10 commented Mar 3, 2019

RainbowCookie32 commented Mar 3, 2019 • edited Loading

elad335 commented Mar 3, 2019

RainbowCookie32 commented Mar 3, 2019 • edited Loading

Xcedf commented Mar 8, 2019

kd-11 Mar 8, 2019

Choose a reason for hiding this comment

kd-11 left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

elad335 commented Mar 2, 2019 •

edited

Loading

RainbowCookie32 commented Mar 2, 2019 •

edited

Loading

elad335 commented Mar 3, 2019 •

edited

Loading

RainbowCookie32 commented Mar 3, 2019 •

edited

Loading

RainbowCookie32 commented Mar 3, 2019 •

edited

Loading