Fixup for spu/ppu disasm prs #6782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nekotekina
reviewed
Oct 16, 2019
- Don't allow all args to be nullptr at once. - Fill listBuf with zeroes for unwritten entries - Fix userId set in listBuf Similarly to what the firmware does
Also first check for EINVAL in sys_spu_thread_set_spu_cfg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also contains two more commits:
cellUserInfoGetList changes:
Restores lost commit from pr #5346, the point is to not reset spu signotify config in gropu_start(), error checking ordering fix. (the pr includes the testcases)