Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay: Add frametime counter to overlay presets: minimal, low, medium. #6892

Closed
wants to merge 1 commit into from

Conversation

illusion0001
Copy link
Contributor

Added a frametime counter to presets below High.

@illusion0001 illusion0001 changed the title Add frametime counter to overlay presets: minimal, low, medium. overlay: Add frametime counter to overlay presets: minimal, low, medium. Oct 26, 2019
@MSuih
Copy link
Member

MSuih commented Oct 26, 2019

I'd prefer if there were an option for this, as I don't really like having the frametime visible myself.

@lextra2
Copy link

lextra2 commented Oct 26, 2019

No thanks on minimal or low (there is a reason they are called that). Medium is fine I guess.

@illusion0001 illusion0001 force-pushed the frametime-overlay branch 2 times, most recently from 4359b62 to 680c9c4 Compare October 27, 2019 08:13
Overlay presets:
Minimal
Low
Medium
now has a frametime counter.
@VelocityRa
Copy link
Member

Not a big fan either, especially for Low.

  1. It's almost double the screen real estate, for what's basically redundant information.
  2. More visual noise
  3. Useless to the vast majority of users
  4. Everyone else that would want it could just use High

@kd-11
Copy link
Contributor

kd-11 commented Oct 28, 2019

Make this a configurable option defaulting to off since most people seem to dislike it. Imo it's mostly unnecessary since the high setting already exists if you want extra stats. Makes more sense to implement a "custom" setting and choosing which stats you want on OSD instead.

@lextra2
Copy link

lextra2 commented Oct 28, 2019

It would also make more sense if frametime was a graph representing the last ~4 seconds instead of a plain value, since it is mostly used to check for frametime spikes anyway.

Like this one from RivaTuner Statistics Server for example:

frametime-graph

@illusion0001 illusion0001 deleted the frametime-overlay branch October 31, 2019 09:19
@VelocityRa VelocityRa mentioned this pull request Nov 9, 2019
@illusion0001 illusion0001 restored the frametime-overlay branch November 22, 2019 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants