sys_spu Fixup after #6864 #6917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated spu_channel_4_t::clear to be thread-safe outside the mutex. |
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Oct 29, 2019
Clear the last value before zeroing count, fixes a rare race introduced by RPCS3#6917.
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Oct 29, 2019
Fixes a possible unintended state (overriding last element with 0) by clearing last element before zeroing count. (race between the exiting thread and the one calls sys_spu_thread_write_mb). Regressed by RPCS3#6917.
Merged
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Oct 31, 2019
* Make spu_channel_4_t::clear() atomic: Clear the last value before zeroing count, fixes a rare race introduced by RPCS3#6917. * Optimize push() to use vectorization and less atomic instructions. * Optimize try_pop() to use less atomic instructions
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Oct 31, 2019
* Make spu_channel_4_t::clear() atomic: Clear the last value before zeroing count, fixes a rare race introduced by RPCS3#6917. * Optimize push() to use vectorization and less atomic instructions. * Optimize try_pop() to use less atomic instructions
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Oct 31, 2019
* Make spu_channel_4_t::clear() atomic: Clear the last value before zeroing count, fixes a rare race introduced by RPCS3#6917. * Optimize push() to use vectorization and less atomic instructions. * Optimize try_pop() to use less atomic instructions
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Oct 31, 2019
* Make spu_channel_4_t::clear() atomic: Clear the last value before zeroing count, fixes a rare race introduced by RPCS3#6917. * Optimize push() to use vectorization and less atomic instructions. * Optimize try_pop() to use less atomic instructions
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Nov 1, 2019
Clear the last value before zeroing count, fixes a rare race introduced by RPCS3#6917.
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Dec 6, 2019
Clear the last value before zeroing count, fixes a rare race introduced by RPCS3#6917.
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Dec 31, 2019
Clear the last value before zeroing count, fixes a rare race introduced by RPCS3#6917.
elad335
added a commit
to elad335/rpcs3
that referenced
this pull request
Dec 31, 2019
By removing separate value3 write, fixes a rare race introduced by RPCS3#6917.
Nekotekina
pushed a commit
that referenced
this pull request
Dec 31, 2019
By removing separate value3 write, fixes a rare race introduced by #6917.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
must be cleared for each thread separerately.