Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys_process: Fix sys_process_get_id, add error_code #7246

Merged
merged 2 commits into from Jan 14, 2020
Merged

Conversation

@elad335
Copy link
Contributor

elad335 commented Jan 14, 2020

  • Due to signed checks and do-while behavior of sys_process_get_id ids processing (checking bufsize), negative and 0 values are treated as 1.
  • sys_process_get_id and sys_process_get_id2 are not the same syscall handling code, infact they have a few different error checks and capabilities.

Testcase : https://github.com/elad335/myps3tests/tree/master/ppu_tests/sys_process_get_id

@elad335 elad335 requested a review from Nekotekina Jan 14, 2020
@Nekotekina Nekotekina merged commit 01035d3 into RPCS3:master Jan 14, 2020
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@elad335 elad335 deleted the elad335:util branch Jan 15, 2020
mavethee added a commit to mavethee/rpcs3 that referenced this pull request Jan 15, 2020
sys_process: Fix sys_process_get_id, add error_code (RPCS3#7246) to match with base fork.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.