GUI Icon improvements #7453
Merged
GUI Icon improvements #7453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| painter.setPen(QPen(Qt::blue, 2)); | ||
| painter.drawEllipse(QRectF(stick_x, stick_y, 1, 1)); | ||
|
|
||
| l->setPixmap(pixmap); |
There was a problem hiding this comment.
Good improvements to readability!
CookiePLMonster
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read on discord that some icons looked like crap with the "new high dpi settings" and that we should revert those changes.
So I tried it on my end and set my windows 10 scaling to 125% and it seems they looked bad after all.
Improvements
Old vs. New