SPU Debugger Improvements: Add MR mnemonics, constants propagation and more #9113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elad335
commented
Oct 22, 2020
•
elad335
commented
- Add made-up MR mnemonic for [ORI x, y, 0] and [SHLQBYI x, y, 0] instructions. MR as in "move register" as the PowerPC mnemonic.
- Optimize debugger thread context update a bit by not iterating over all CELL threads, only the single relevant thread ID to us.
- Detect simple constant command propagation in WRCH and a few more instructoios which should work in most of the cases.
- Add SPURS workload argument in kernel-explorer.
- Cleanup SPU channels logging. (rely entirely on spu_ch_name)
- Fix bug in CPUDisAsm::SignedHex regarding INTx_MIN.
elad335
force-pushed
the
spu-debug
branch
5 times, most recently
from
70d714a
to
07be04a
Compare
Some correctness fixes as well: dont use raw pointers where its not compatible, use std::weak_ptr instead.
elad335
force-pushed
the
spu-debug
branch
2 times, most recently
from
4045a89
to
887895f
Compare
elad335
changed the title
|
SPU instruction regsiters' value constant propagation: |
elad335
force-pushed
the
spu-debug
branch
4 times, most recently
from
9a36d27
to
77e726f
Compare
elad335
changed the title
elad335
force-pushed
the
spu-debug
branch
5 times, most recently
from
5980509
to
2eaf0ae
Compare
Only functional in WRCH and ILHU+IOHL pattern atm. ILHU+IOHL is extremely common pattern to create 32-bit constants such as SPPU libraries error codes.
It didnt take into account INTx_MIN. (UB for std::abs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.