Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit mini-db #9728

Merged
merged 5 commits into from
Feb 6, 2021
Merged

Commit mini-db #9728

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c32fec7
Create mini-cache for commits
Nekotekina Feb 5, 2021
d6dcab4
Updater: add minor sanity check
Nekotekina Feb 5, 2021
cb32fd1
Add supporters
Nekotekina Feb 5, 2021
25827c1
Make out of source builds get copy of /GuiConfigs/, /git/, etc.
Nekotekina Feb 6, 2021
1b34fa2
Update commits.lst (example)
Nekotekina Feb 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions rpcs3/rpcs3qt/update_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,12 @@ bool update_manager::handle_json(bool automatic, bool check_only, const QByteArr
m_expected_hash = latest[os]["checksum"].toString().toStdString();
m_expected_size = latest[os]["size"].toInt();

if (!m_request_url.starts_with("https://github.com/RPCS3/rpcs3"))
Copy link
Member

@AniLeo AniLeo Feb 6, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dangerous change, will break the update on every old build if we're ever forced to do another build host migration such as the previous GitHub -> AppVeyor

{
update_log.fatal("Bad url: %s", m_request_url);
return false;
}

if (check_only)
{
m_downloader->close_progress_dialog();
Expand Down