Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SteamCommunityBridge] Support for Workshop category #1172

Merged
merged 11 commits into from
Jun 16, 2019

Conversation

thefranke
Copy link
Contributor

This PR contains an enhancement to support the Workshop category for a given Steam app ID.

Copy link
Member

@logmanoriginal logmanoriginal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Travis is still complaining (as always). Find below some comments. This should also satisfy Travis (hopefully 🙏).

bridges/SteamCommunityBridge.php Outdated Show resolved Hide resolved
bridges/SteamCommunityBridge.php Outdated Show resolved Hide resolved
bridges/SteamCommunityBridge.php Outdated Show resolved Hide resolved
bridges/SteamCommunityBridge.php Outdated Show resolved Hide resolved
bridges/SteamCommunityBridge.php Outdated Show resolved Hide resolved
bridges/SteamCommunityBridge.php Outdated Show resolved Hide resolved
@logmanoriginal
Copy link
Member

Travis is very pleased, as am I 😄
Thanks again for the PR!

@logmanoriginal logmanoriginal merged commit 849eaeb into RSS-Bridge:master Jun 16, 2019
@thefranke
Copy link
Contributor Author

Thanks for the review, I was getting confused by the results of TravisCI, but now everything is green \o/

@logmanoriginal
Copy link
Member

Once they finished transfer of all their services, Travis will integrate better into GitHub.
Until then we need to be patient 🐌

infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants