[DerpibooruBridge] make it work (again) #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current derpibooru script doesn't work, so I fixed it using the api described here: https://derpibooru.org/pages/api
This is mostly minimal change ensuring it work again, but I also handled the case where source_url isn't specified, for exemple for image that are originaly uploaded on derpibooru.
I tested with some input, including inputs with colons
I also renamed 'post' by 'image', as this seem to correspond with the website more (thought I don't know the history of derpibooru).
I haven't fixed the detectParameters function (I have no knowledge and wish to fix regex), as there are often multiple search argument, and it only work for simple urls.
Also, checked filter work as expected.
@Roliga : the maintainer