New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AO3Bridge: move tags to categories and remove duplicate fic summary #4031
Conversation
Pull request artifacts
last change: Wednesday 2024-03-27 20:49:41 |
@@ -123,6 +137,10 @@ private function collectList($url) | |||
$response = $httpClient->request($url, $agent); | |||
$html = \str_get_html($response->getBody()); | |||
$html = defaultLinkTo($html, self::URI); | |||
// remove duplicate fic summary | |||
if ($ficsum = $html->find('#workskin > .preface > .summary', 0)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for next time, please dont do assignment inside if statements.
the change introduced this error:
|
Ah my mistake! I hadn't thought to test against user pages. The issue can be fixed by removing the |
yes pls make pr |
No description provided.