Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AO3Bridge: move tags to categories and remove duplicate fic summary #4031

Merged
merged 2 commits into from Mar 28, 2024
Merged

AO3Bridge: move tags to categories and remove duplicate fic summary #4031

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
822e77c
AO3Bridge: move tags to categories and remove duplicate fic summary
Phantop Mar 25, 2024
3bbce6d
[AO3Bridge] Fix tag html entity encoding
Phantop Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 19 additions & 1 deletion bridges/AO3Bridge.php
View file
Open in desktop
Expand Up @@ -91,12 +91,26 @@ private function collectList($url)
continue; // discard deleted works
}
$item['title'] = $title->plaintext;
$item['content'] = $element;
$item['uri'] = $title->href;

$strdate = $element->find('div p.datetime', 0)->plaintext;
$item['timestamp'] = strtotime($strdate);

// detach from rest of page because remove() is buggy
$element = str_get_html($element->outertext());
$tags = $element->find('ul.required-tags', 0);
foreach ($tags->childNodes() as $tag) {
$item['categories'][] = html_entity_decode($tag->plaintext);
}
$tags->remove();
$tags = $element->find('ul.tags', 0);
foreach ($tags->childNodes() as $tag) {
$item['categories'][] = html_entity_decode($tag->plaintext);
}
$tags->remove();

$item['content'] = implode('', $element->childNodes());

$chapters = $element->find('dl dd.chapters', 0);
// bookmarked series and external works do not have a chapters count
$chapters = (isset($chapters) ? $chapters->plaintext : 0);
Expand All @@ -123,6 +137,10 @@ private function collectList($url)
$response = $httpClient->request($url, $agent);
$html = \str_get_html($response->getBody());
$html = defaultLinkTo($html, self::URI);
// remove duplicate fic summary
if ($ficsum = $html->find('#workskin > .preface > .summary', 0)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for next time, please dont do assignment inside if statements.

$ficsum->remove();
}
$item['content'] .= $html->find('#workskin', 0);
}

Expand Down