-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AtomFormat] improved to comply with RFC 4287 #995
[AtomFormat] improved to comply with RFC 4287 #995
Conversation
The http://purl.org/syndication/thread/1.0 namespace has been removed as RSS-Bridge is by no means even capable to reference threaded items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
This is a very complex PR, please split it into multiple pieces:
- Fixing the existing format
- Extending the format
- Adding unit tests
That way reviews are easier to do.
Please also don't align code using tabs. It may work in your editor, but it looks awful in mine (because I use different tab width). The GitHub editor for example is also harder to read like this:
For the core files (anything except bridges), please use curly braces for if-statements:
if($condition === true) {
// code here
}
Thanks for your suggestions, please see the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your suggestions, please see the changes.
Thanks, one final thing before I can merge. The alignment tabs need to be removed. Here is another example from my editor (using a tab width of 4): Here is tab width of 2 for comparison: I'm pretty sure it looks fine in your editor, but there is no way to make alignments work for everyone, so we should avoid using them. |
This should do it. |
Merged. Thanks for the updates! |
This PR improves the Atom format to comply with RFC 4287. It includes unit tests for verification.