Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setSelectionColor Issues #12

Closed
nwoolls opened this issue Sep 30, 2012 · 5 comments
Closed

setSelectionColor Issues #12

nwoolls opened this issue Sep 30, 2012 · 5 comments
Labels

Comments

@nwoolls
Copy link

nwoolls commented Sep 30, 2012

The implementation for setSelectionColor seems hit-or-miss. For instance:

self.colorPicker.selectionColor = [UIColor blueColor]; //works
self.colorPicker.selectionColor = [UIColor yellowColor]; //works
self.colorPicker.selectionColor = [UIColor blackColor]; //selects green
self.colorPicker.selectionColor = [UIColor redColor]; //crashes the app

@kostassite
Copy link

Hi,
I have fixed this problem and it is in this commit. kostassite@dcd3db1
I have made a pull request including adding of arc in the code. Thanks

@uzairbinnisar
Copy link

self.colorPicker.selectionColor = [UIColor blackColor]; //selects green

it still exists and it fails on colors which are not displayed in color picker circle... it selects only those colors which come under the present brightness....

@azraelx23
Copy link

So, is there any solutions to these problem?
It still cannot implement :

  • self.colorPicker.selectionColor = [UIColor blackColor];

@RSully
Copy link
Owner

RSully commented Dec 13, 2012

I'm not sure that @kostassite's solution actually fixes the underlying problem. I'll see if I can look at this a little more closely soon. Feel free to try his branch and let us know what you find!

@RSully
Copy link
Owner

RSully commented Mar 12, 2013

I think this issue has now been fixed in #17.

@RSully RSully closed this as completed Mar 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants