-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kernel][mutex] fix bug of thread exit without releasing mutex & add error check log #9337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
为什么要加no pi |
优先级继承方式的mutex实现较重(频繁的任务线程优先级调整),对性能有影响。 |
zmshahaha
force-pushed
the
mutex
branch
2 times, most recently
from
August 23, 2024 08:37
83cafa8
to
1afc335
Compare
zmshahaha
changed the title
[kernel][mutex]add mutex NO_PI flag and error check log
[kernel][mutex] fix bug of thread exit without releasing mutex & add mutex RECURSIVE flag & add error check log
Aug 23, 2024
zmshahaha
force-pushed
the
mutex
branch
2 times, most recently
from
August 23, 2024 08:40
ad54ac6
to
606f828
Compare
没看懂这个ci报错 |
还有包括,当试图去持有mutex,但超时任务恢复的时候,需要对mutex的优先级进行调整的。 |
zmshahaha
force-pushed
the
mutex
branch
2 times, most recently
from
August 26, 2024 01:38
36cc2de
to
f7e9e8d
Compare
zmshahaha
changed the title
[kernel][mutex] fix bug of thread exit without releasing mutex & add mutex RECURSIVE flag & add error check log
[kernel][mutex] fix bug of thread exit without releasing mutex & add error check log
Aug 26, 2024
polarvid
suggested changes
Aug 28, 2024
2. add error check log
这个我测的没有问题,代码上也能看到mutex超时恢复调整优先级的逻辑 |
This was referenced Sep 4, 2024
BernardXiong
approved these changes
Sep 7, 2024
mysterywolf
approved these changes
Sep 9, 2024
@polarvid 麻烦再review一下呗 |
mysterywolf
requested changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI 有错误
polarvid
approved these changes
Sep 10, 2024
感觉是ci有bug |
可以将这个BSP改成-O2编译 |
编译问题修了 |
mysterywolf
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up