Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utest]fix race in mutex tc & add recurse lock tc #9365

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

zmshahaha
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@zmshahaha zmshahaha requested a review from Rbb666 as a code owner August 29, 2024 10:09
@zmshahaha zmshahaha force-pushed the mutex_tc_fix branch 2 times, most recently from 81494b6 to c860cd2 Compare August 30, 2024 06:39
@polarvid polarvid added the +1 Agree +1 label Sep 2, 2024
@Rbb666
Copy link
Member

Rbb666 commented Sep 2, 2024

image
这个文件要格式化下,谢谢。

@mysterywolf
Copy link
Member

CI 除了格式检查之外,貌似有个检查没过

rt_thread_mdelay(1000);
while (_sync_flag != 3)
{
rt_thread_mdelay(1000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个delay 确认一下 在QEMU仿真世界里是否需要这么长的时间?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最好是全部换成 IPC,用时延的用例都不怎么靠谱。经常是换个平台就跑不起来了。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mysterywolf mysterywolf added change req change requestion -1 No vote labels Sep 2, 2024
@zmshahaha
Copy link
Contributor Author

zmshahaha commented Sep 4, 2024

这个pr依赖于 #9337 ,这个pr修了一个线程对一个mutex两次take,退出时没有完全释放的bug,这个pr有依赖

delay 1000的已改成delay10

@github-actions github-actions bot added the Kernel PR has src relate code label Sep 6, 2024
@mysterywolf mysterywolf closed this Sep 6, 2024
@mysterywolf mysterywolf reopened this Sep 6, 2024
@mysterywolf mysterywolf removed the -1 No vote label Sep 11, 2024
@mysterywolf
Copy link
Member

@zmshahaha CI 需要修一下,把ROM扩大 或者改成-O2

@zmshahaha
Copy link
Contributor Author

@zmshahaha CI 需要修一下,把ROM扩大 或者改成-O2

已修

@mysterywolf mysterywolf merged commit 0edd2e7 into RT-Thread:master Sep 11, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP change req change requestion Kernel PR has src relate code testcase +1 Agree +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants