Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"QueryGraphInterpreter cannot interpret this QueryGraph" for one-hop #1136

Closed
MarkDWilliams opened this issue Dec 2, 2020 · 2 comments
Closed

Comments

@MarkDWilliams
Copy link

I submitted the following query to ARAX through the ARS and received an error that the query graph was not interpretable. Please let me know if there was any issue with my query_graph.

https://ars.transltr.io/ars/api/messages/30fed63c-aa5b-4ba8-8874-5a458b5d0404

{"message":
{
  "query_graph": {
    "nodes": [
      {
        "id": "n0",
        "type": "disease",
        "curie:":"DOID:0050427"
      },
      {
        "id": "n1",
        "type": "phenotypic_feature",
        "set": false
      }
    ],
    "edges": [
      {
        "id": "e0",
        "source_id": "n0",
        "target_id": "n1"
      }
    ]
  }
}}
@edeutsch
Copy link
Collaborator

edeutsch commented Dec 2, 2020

Clearly we need to improve our validation and error reporting. The problem with your query_graph is here:

    "curie:":"DOID:0050427"

The key has a colon in it ( "curie:" instead of "curie")
If you remove that, it works.
I will add validation of the input message. I thought our framework did this. Ah, but with additionalProperties: true, having things like "curie:" is legal. And having no "curie" is legal. I will add code that will complain about unexpected keys.

Thanks for testing!

@edeutsch
Copy link
Collaborator

edeutsch commented Dec 2, 2020

@MarkDWilliams I have just pushed a fix so that the following warnings are displayed with the above input query_graph:

2020-12-02 22:49:22.762145 WARNING: Query graph node 'n0' has an unexpected property 'curie:'. Don't know what to do with that, but will continue
2020-12-02 22:49:22.762152 WARNING: Query graph node 'n1' has an unexpected property 'set'. Don't know what to do with that, but will continue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants