Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed shell test styles #52

Closed
hpwxf opened this issue Aug 6, 2020 · 2 comments
Closed

Mixed shell test styles #52

hpwxf opened this issue Aug 6, 2020 · 2 comments
Labels

Comments

@hpwxf
Copy link
Collaborator

hpwxf commented Aug 6, 2020

In travis-ci shell script, there are two styles for tests:

  • One bracket style
if [ "$VALGRIND" = true ]; then 
  • Two brackets style
if [[ "$SONAR" == true ]]; then

The first one is POSIX compliant and the second one is more flexible by only support by ks, bash and zsh.

Should we define a reference style?

Notes:

@RUrlus
Copy link
Owner

RUrlus commented Aug 23, 2020

Going by the stack overflow answer I would argue that the two brackets style is preferred as portability is not a major concern here.

@RUrlus RUrlus added the CICD label Aug 23, 2020
@RUrlus
Copy link
Owner

RUrlus commented Mar 19, 2021

Should be fixed in the move to #74

@RUrlus RUrlus closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants