Return 304 code during a hour #130
Conversation
- Inspired in https://github.com/widmogrod/zf2-semi-http-cache - Add last modified and cache control
|
I made other changes it's for me works good like that! |
|
I'm not sure if this should be handled by AM... The idea is neat, but I see a couple of possible improvements
|
|
If asset manager serve files why shouldn't it handle cache to browser? |
|
@guilherme-santos that would only be acceptable if we had cache invalidation as well (which we don't right now)... Caching should be handled via the file cache or |
|
@guilherme-santos The recommended way of dealing with this is varnish. You use the asset manager to make sure lookup, and bundling assets with modules is possible. You use varnish to handle actual serving and caching. The reason for this is that this module doesn't do what you want yet. And seeing how almost nobody seems to need it it hasn't been contributed either. |
|
I don't understand, actually (as a client) I need the files are served, to fix the limitation of zendframework, that all files should be in main public folder, you create this module... I think this module should be transparent to client, it should be like a apache serving it... I don't know why it's not good implement this logic here..! @Ocramius I don't understand what you mean invalidation cache? |
|
@guilherme-santos In all fairness I do agree that this module should handle that. But at this point it doesn't, and I don't think that breaking BC is the solution. We've already been discussing a v2, perhaps I can create a branch for that and have BC-breaking PRs be pointed there. I'd first open this up for discussion, what do you think? |
|
For me it's ok! Thanks ;) |
Actually If I can get the path (like
$assetManager->getAssetPath()) I'll get the modified time usingfilemtime(), it'll compare and return right LastModified... And the cache will work better, not only for a hour.