-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies update with assetic framework #221
Conversation
Hi, Best regards, |
In its current state it can't be merged (due to conflicts). As to whether or not this is a wanted change: I'm not sure. Judges? |
I'll try to rebase it |
2e39e51
to
c98b217
Compare
@RWOverdijk rebased! I think a lot of people needs it. Big projects need to be updated, and it's a problem if a library doesn't allow it. |
Alrighty. I'm down with that. Just pinging @Ocramius so he can stop me if needed. I'll try to get on that tomorrow at the end of the day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: just beware that tagging requires a major version bump due to signatures changed because of third-party dependency bump cascading into signatures in this package.
@@ -9,7 +9,7 @@ interface ResolverInterface | |||
* | |||
* @param string $path The path to resolve. | |||
* | |||
* @return \Assetic\Asset\AssetInterface|null Asset instance when found, null when not. | |||
* @return \Assetic\Contracts\Asset\AssetInterface|null Asset instance when found, null when not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important: while it is indeed a third-party dependency that changes, this calls for a major version update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, as I mentioned before, this is a BC break. Also, some functionalities are removed because not available in the new assetic library.
@@ -138,7 +138,7 @@ protected function ensureByFilter(AssetInterface $asset, $filter) | |||
|
|||
$filterClass = $filter; | |||
|
|||
if (!is_subclass_of($filterClass, 'Assetic\Filter\FilterInterface', true)) { | |||
if (!is_subclass_of($filterClass, 'Assetic\Contracts\Filter\FilterInterface', true)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to other code changes that moved symbols, this is also a BC break
This branch is based on #219. It updates tests and dependencies.
Changelog
Added
AssetManager\Cache\PsrSimpleCacheAdapter
to use a PSR-16 cache implementation for Assetic cacheChanges
assetic-php/assetic
, see 2.0.0 release notes for BC Breakslaminas/laminas-stdlib
minimum version to3.2.1
AssetManager\Resolver\ResolverInterface
should now returnAssetic\Contracts\Asset\AssetInterface|null
BC Break
assetic-php/assetic
, see 2.0.0 release notes for BC Breaks.The most notable changes used in this is library are:
Assetic\Asset\AssetInterface
moved inAssetic\Contracts\Asset\AssetInterface
Assetic\Asset\FilterInterface
moved inAssetic\Contracts\Asset\FilterInterface
Assetic\Asset\CacheInterface
moved inAssetic\Contracts\Asset\CacheInterface
AssetManager\Resolver\ResolverInterface
should now returnAssetic\Contracts\Asset\AssetInterface|null