Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionary Coloring #1164

Merged
merged 2 commits into from
Mar 17, 2017
Merged

Dictionary Coloring #1164

merged 2 commits into from
Mar 17, 2017

Conversation

bhargavvader
Copy link
Contributor

This is an update for the word-colouring notebook - I've had some requests about how to statically color a dictionary, and have demonstrated the same in the notebook.

@tmylk
Copy link
Contributor

tmylk commented Feb 24, 2017

Could you please clarify what is the reason for the incorrect coloring of 'mud'? Lack of context in get_term_topics or in the corpus?

@bhargavvader
Copy link
Contributor Author

I reckon it's because of the small vocabulary the lda model isn't trained perfectly; will investigate and see the exact reason.

@tmylk
Copy link
Contributor

tmylk commented Mar 2, 2017

could you please remove/correct the text about it? will merge after it's fixed

@bhargavvader
Copy link
Contributor Author

Sorry, been busy last couple of days. Would you just like the text to be removed? I thought I could spend some time in fixing it by fine-tuning the model.

@tmylk
Copy link
Contributor

tmylk commented Mar 9, 2017

Just need to be explicit in that the coloring is correct according to the model. But the model is wrong because of small corpus.

@bhargavvader
Copy link
Contributor Author

Sorry about the delay - I've added a small explanation now.

@bhargavvader
Copy link
Contributor Author

@tmylk unrelated tests failing.

@tmylk
Copy link
Contributor

tmylk commented Mar 17, 2017

Travis tests re-ran after smart_open update

@tmylk tmylk merged commit 3053459 into piskvorky:develop Mar 17, 2017
@tmylk
Copy link
Contributor

tmylk commented Mar 17, 2017

Thx for the update!

@bhargavvader bhargavvader deleted the dictionary branch April 12, 2017 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants