Fix tutorial (filter_token calls compactify automatically) #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piskvorky
requested changes
Jul 25, 2017
| @@ -387,7 +387,6 @@ | |||
| "dictionary.filter_tokens(stop_ids + once_ids)\n", | |||
| "\n", | |||
| "# remove gaps in id sequence after words that were removed\n", | |||
| "dictionary.compactify()\n", | |||
There was a problem hiding this comment.
With the code gone, let's remove the orphaned comment above too.
…and commit 4863040), so I fixed that point in tutorial.
|
Oh sorry, was sure I've removed it. Done. |
|
Thank you @VorontsovIE, congratz with your first conribution 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filter_token calls compactify automatically (see issue #326 and commit 4863040), so I fixed that point in tutorial.