Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor corrections and improvements in Any*Vec docstrings #2345

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

tobycheese
Copy link
Contributor

Fixed some small things in docstrings and in an exception over which I stumbled while making myself familiar with gensim:

  • Docstrings still mention 'sentences argument, while in code this is now called 'documents'
  • Clarify that when not passing training data, the model is left uninitialized
  • A generator is also an iterator. 'Sequence' might be a better term (forgotten to mention that one in my commit msg)

…or docstring clarifications over which I stumbled
@piskvorky
Copy link
Owner

Related to #2347.

@menshikh-iv
Copy link
Contributor

Thanks @tobycheese, congratz with the first contribution 🥇

@menshikh-iv menshikh-iv changed the title Minor corrections and improvements in docstrings and in an exception Minor corrections and improvements in Any*Vec docstrings Jan 22, 2019
@menshikh-iv menshikh-iv merged commit 9819ce8 into piskvorky:develop Jan 22, 2019
@tobycheese tobycheese deleted the misc_doc_fixes branch January 22, 2019 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants