Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate setup.py from distutils to setuptools #3274

Merged

Conversation

geojacobm6
Copy link
Contributor

Fixes #3272

Migrate setup.py from distutils to setuptools

distutils is going away in a future version of Python

https://docs.python.org/3/whatsnew/3.10.html#distutils-deprecated

@codecov
Copy link

codecov bot commented Dec 4, 2021

Codecov Report

Merging #3274 (701cb45) into develop (a9fc7fc) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head 701cb45 differs from pull request most recent head be503bd. Consider uploading reports for the commit be503bd to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3274      +/-   ##
===========================================
- Coverage    79.03%   78.91%   -0.12%     
===========================================
  Files           68       68              
  Lines        11781    11781              
===========================================
- Hits          9311     9297      -14     
- Misses        2470     2484      +14     
Impacted Files Coverage Δ
gensim/corpora/dictionary.py 94.17% <ø> (ø)
gensim/corpora/wikicorpus.py 82.21% <0.00%> (-5.29%) ⬇️
gensim/utils.py 71.05% <0.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9fc7fc...be503bd. Read the comment docs.

@mpenkov
Copy link
Collaborator

mpenkov commented Dec 5, 2021

Good work, thank you!

@mpenkov mpenkov merged commit 48d6e55 into piskvorky:develop Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate setup.py from distutils to setuptools
2 participants