-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling mistakes 🔑 #10
Conversation
Co-authored-by: G. Moraleda <guille.moraleda@gmail.com>
Thanks for the update. You may want to update the PR description as well according to the https://github.com/RadarCOVID/radar-covid-ios/blob/master/CONTRIBUTING.md file. |
@gmoraleda as per
don't you think the 🔑 should be included at the top of the body and not in the title? 🤔 |
@juanjo-ramos I guess is just about making clear that the contributing document has been read. Whether the emoji goes in the title or in the description should be secondary 😄 |
@gmoraleda yeah, I agree. I honestly was thinking about the PR I opened. When I read the guideline, I thought it made more sense to have it in the title rather than the body in case the body is not even read if emoji is not seen in the title 🙂 |
Thanks, Comment that the strings come from the webServices and the content shown in the xib / storyboards are merely informative for the developer. |
🔑 Minor spelling mistakes.