Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling mistakes 🔑 #10

Closed
wants to merge 5 commits into from
Closed

Spelling mistakes 🔑 #10

wants to merge 5 commits into from

Conversation

imartinezl
Copy link

@imartinezl imartinezl commented Sep 10, 2020

🔑 Minor spelling mistakes.

Co-authored-by: G. Moraleda <guille.moraleda@gmail.com>
@gmoraleda
Copy link

Thanks for the update. You may want to update the PR description as well according to the https://github.com/RadarCOVID/radar-covid-ios/blob/master/CONTRIBUTING.md file.

@imartinezl imartinezl changed the title Spelling mistakes Spelling mistakes 🔑 Sep 11, 2020
@juanjo-ramos
Copy link

@gmoraleda as per

If you include the 🔑 emoji at the top of the body of your issue or pull request, we'll know that you've given this your full attention and are doing your best to help!

don't you think the 🔑 should be included at the top of the body and not in the title? 🤔

@gmoraleda
Copy link

@juanjo-ramos I guess is just about making clear that the contributing document has been read. Whether the emoji goes in the title or in the description should be secondary 😄

@juanjo-ramos
Copy link

@gmoraleda yeah, I agree. I honestly was thinking about the PR I opened. When I read the guideline, I thought it made more sense to have it in the title rather than the body in case the body is not even read if emoji is not seen in the title 🙂

@gmoraleda gmoraleda mentioned this pull request Sep 12, 2020
@daronleaj
Copy link

Thanks,
Already fixed from new version, no merge needed.

Comment that the strings come from the webServices and the content shown in the xib / storyboards are merely informative for the developer.

@daronleaj daronleaj closed this Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants