Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Add Paused" option to Deluge and Transmission #3038

Merged
merged 3 commits into from
Sep 18, 2018
Merged

Add "Add Paused" option to Deluge and Transmission #3038

merged 3 commits into from
Sep 18, 2018

Conversation

cookandy
Copy link
Contributor

Database Migration

NO

Description

Adds an add paused option to deluge and transmission clients. Based on a similar commit in Sonarr.

Todos

  • Tests

Issues Fixed or Closed by this PR

@Qstick
Copy link
Member

Qstick commented Sep 18, 2018

Any reason you didn’t pull the changes to deluge.cs from the Sonarr commit?

@cookandy
Copy link
Contributor Author

Didn't think they were relevant, but I can certainly add them. Let me know!

@Qstick
Copy link
Member

Qstick commented Sep 18, 2018

If not then we are setting remove_at_ratio twice. Once at add (part of what you just added) and then again after add when its called back to the proxy from these lines in deluge.cs. Just avoids two calls to Deluge

@cookandy
Copy link
Contributor Author

Good catch. I just pushed that change ☝️

@galli-leo galli-leo merged commit 75b486c into Radarr:develop Sep 18, 2018
ta264 pushed a commit that referenced this pull request Dec 10, 2019
@markus101 @Qstick
Improve certificate validation registration
f7addec 
Fixed: Certificate validation during startup
Fixed: Errors removing Windows service

Closes #3037
Closes #3038
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qstick Qstick Qstick approved these changes

@galli-leo galli-leo galli-leo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cookandy @Qstick @galli-leo