Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom style and remove bootstrap. #15

Open
Radi85 opened this issue May 17, 2020 · 6 comments
Open

Use custom style and remove bootstrap. #15

Radi85 opened this issue May 17, 2020 · 6 comments
Labels
help wanted Extra attention is needed
Milestone

Comments

@Radi85
Copy link
Owner

Radi85 commented May 17, 2020

In order to reduce the app dependencies, I would like to replace bootstrap with a custom CSS.

@Radi85 Radi85 added the help wanted Extra attention is needed label May 17, 2020
@MrCordeiro
Copy link

MrCordeiro commented Nov 18, 2020

Would you really need it as a feature though?
I replaced it in my project by overriding the templates.

@Radi85
Copy link
Owner Author

Radi85 commented Nov 18, 2020

That's good news 😃
However, without overriding the templates, you would still need the bootstrap.
Removing it makes the app more customizable by overriding CSS classes only instead of overriding the whole template.
IMHO, it would be a cool feature but needs a lot of work.

@Radi85 Radi85 added this to the 3.0.0 milestone Jan 4, 2021
@spsphulse
Copy link

Would you really need it as a feature though?
I replaced it in my project by overriding the templates.

Can you share how you did this or maybe the repo where you did this? Utility frameworks are foreign to me :)
I added similar feature requesting support for Tailwind. Your code might help make me changes.

@MrCordeiro
Copy link

Would you really need it as a feature though?
I replaced it in my project by overriding the templates.

Can you share how you did this or maybe the repo where you did this? Utility frameworks are foreign to me :)
I added similar feature requesting support for Tailwind. Your code might help make me changes.

Sorry for taking so long to answer this (I had bookmarked it and then forgotten about it).
It's not overly complicated. Just like any Django project, you can override the templates of any third-party app by creating HTML files with the same names in your root template folder.

An easy way to do it is to create a comment folder inside your templates folder (as that's the name of this app) and copy all the content from this location into your project. Then you can treat these template files as your own and change them as you wish (just don't change their names).

@Radi85 Radi85 modified the milestones: 3.0.0, 2.7.0 Feb 27, 2021
@Radi85 Radi85 modified the milestones: 2.7.0, 2.8.0 Jul 19, 2021
@abhiabhi94 abhiabhi94 modified the milestones: 2.8.0, 2.9.0 Jun 19, 2022
@vishalsingha
Copy link

My comment.css file is rendering in debug = True but not in debug = False. All the other css files of project are working in debug is False and True both . What is the reason behind it?

@abhiabhi94
Copy link
Collaborator

abhiabhi94 commented Jul 24, 2022

My comment.css file is rendering in debug = True but not in debug = False. All the other css files of project are working in debug is False and True both . What is the reason behind it?

Basically, django shouldn't ideally be used to serve static files in production mode. For more information, you may read serving static files in production.

Also, just a suggestion, please don't start unrelated threads here. it just messes up the historical logs, and is distracting. if you have something new, feel free to open a issue or discussion as per the needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants