Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block function issue on iOS Safari. #233

Closed
awhileback opened this issue Sep 7, 2021 · 2 comments
Closed

Block function issue on iOS Safari. #233

awhileback opened this issue Sep 7, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@awhileback
Copy link

awhileback commented Sep 7, 2021

Environment

  • python 3.6
  • django 3.2
  • django-comments-dab 2.7.0

Describe the bug

Hello again! I found another block-related bug. On iOS (14.7.1, iPhone SE 2020) the block function works, but Safari doesn't allow the method which tries to replace the content of the comment with the reason why the user was blocked. The error returned is....

NoModificationAllowedError: The object can not be modified.
updateBlockedUserComments — comment.js:515
(anonymous function) — comment.js:544
promiseReactionJob


    [Error] NoModificationAllowedError: The object can not be modified. — comment.js:515
	(anonymous function) (comment.js:551)
	promiseReactionJob

Steps To Reproduce

  1. open a site on an iPhone (all iPhone browsers are Safari, so all are affected)
  2. block a user
  3. ....

Expected behavior

Function return without error. The user is in fact blocked per the database, it appears that this method of replacing the contents of an element don't work on iOS, though.

Unfortunately it seems you need both an iPhone and a MacBook to see this, since iPhones have no debug tools in the browser you have to connect the phone to Safari on a laptop/desktop and then open the phone debugger there.

Screenshots

If applicable, add screenshots to help explain your problem.

@awhileback awhileback added the bug Something isn't working label Sep 7, 2021
@awhileback awhileback changed the title Block function issue on Safari. Block function issue on iOS Safari. Sep 7, 2021
@abhiabhi94
Copy link
Collaborator

thanks @awhileback for the report.

i don't have an iphone to test this, is there a way you know i can reproduce this virtually? from the error that you have posted, it seems an element might not be present in the DOM(document object model) probably, and we are trying to modify its property.

does this occur on other browsers as well?

@awhileback
Copy link
Author

awhileback commented Sep 9, 2021

No, just broken on iOS. The 3 major desktop browsers work fine with the same django installation.

There is an iOS emulator in Xcode if you have a Mac/MacBook, if not, it looks like https://appetize.io may be the best option from what a search turns up, they have a limited free tier.

FYI if you get an emulator working the link to wipe the Safari cache is buried under Settings, Safari, and then "clear history and website data" all the way at the bottom of the menu. There's no gesture or swipe menu function for doing so afaik.

@abhiabhi94 abhiabhi94 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants