Feature addition #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SridarDhandapani
commented
Dec 21, 2016
SridarDhandapani
commented
- Configurable folder prefix for upload.
- Automatically set content-type for uploaded file.
- Keep recently added file at top of the pile for easy reach.
- Few minor operational improvements.
houndci-bot
reviewed
Dec 21, 2016
| @@ -134,6 +134,9 @@ const handleFiles = (files) => { | |||
| * If config is present, instantiates S3Service basing on that information. | |||
| */ | |||
| mb.on('ready', () => { | |||
| const template = [{label: 'Actions', submenu: [{role: "paste"}, {role: "quit"}]}]; | |||
| const menu = Menu.buildFromTemplate(template); | |||
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
houndci-bot
reviewed
Dec 21, 2016
| @@ -134,6 +134,9 @@ const handleFiles = (files) => { | |||
| * If config is present, instantiates S3Service basing on that information. | |||
| */ | |||
| mb.on('ready', () => { | |||
| const template = [{label: 'Actions', submenu: [{role: "paste"}, {role: "quit"}]}]; | |||
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
houndci-bot
reviewed
Dec 21, 2016
| @@ -2,7 +2,7 @@ const menubar = require('menubar'); | |||
| const fs = require('fs'); | |||
| const path = require('path'); | |||
| const notifier = require('node-notifier'); | |||
| const { ipcMain, clipboard } = require('electron'); | |||
| const { ipcMain, clipboard, Menu } = require('electron'); | |||
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
houndci-bot
reviewed
Dec 21, 2016
| @@ -52,11 +53,13 @@ class S3Service { | |||
| */ | |||
| uploadFile(fileName, data) { | |||
| const uploadEventEmitter = new EventEmitter(); | |||
| const mimeType = fileType(data); | |||
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
houndci-bot
reviewed
Dec 21, 2016
| @@ -1,5 +1,6 @@ | |||
| const AWS = require('aws-sdk'); | |||
| const EventEmitter = require('events'); | |||
| const fileType = require('file-type'); | |||
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
houndci-bot
reviewed
Dec 21, 2016
| @@ -3,7 +3,7 @@ const fs = require('fs'); | |||
| * Default file path where credentials will be stored. | |||
| * @type {string} | |||
| */ | |||
| const configFilePath = './.awscredentials.json'; | |||
| const configFilePath = __dirname + '/.awscredentials.json'; | |||
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| "menubar": "^4.1.2", | ||
| "node-notifier": "^4.6.0", | ||
| "react": "^15.2.0", | ||
| "react-dom": "^15.2.0", | ||
| "request": "^2.72.0" | ||
| "request": "^2.72.0", | ||
| "file-type": "^3.9.0" |
| @@ -18,10 +18,10 @@ | |||
| "Amazon Web Services", | |||
| "React" | |||
| ], | |||
| "author": "Rafal Wilinski", | |||
| "author": "Sridar Dhandapani", | |||
|
|
||
| this.s3.upload({ | ||
| Body: data, | ||
| ContentType: mimeType.mime, |
RafalWilinski
requested changes
Dec 22, 2016
|
The indentations are consistent on my vim editor. Let me check the tab
settings.
As for the author section, I assumed you will be cherry picking that part
when you merge. You don't want to be blamed for something I have done...
On Thu, 22 Dec 2016 at 10:36 Rafal Wilinski ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Please do not alter author section of package.json and adapt proper
coding style.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ARQ7TtfMWqGfmsTwN7gR2LBpJLsJSlqUks5rKlKRgaJpZM4LTYwh>
.
--
Sridar Dhandapani
sridar@gmail.com
|
|
I'm using 2 spaces. When it comes to cherry picking I'd rather like to merge whole PR. |
|
Sorry, mistakenly closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.