Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pakku to Blin Testers #26

Merged
merged 5 commits into from
Oct 25, 2020
Merged

Add Pakku to Blin Testers #26

merged 5 commits into from
Oct 25, 2020

Conversation

hythm7
Copy link
Contributor

@hythm7 hythm7 commented Oct 20, 2020

  • Add Blin::Tester::Zef and Blin::Tester::Pakku classes.
  • Changed module extension from .pm6 to .rakumod
  • Add --pm option to switch between testers
    • bin/blin.p6 --pm=zef
    • bin/blin.p6 --pm=pakku

show same bhavior when installed by Pakku or Zef.

Fcntl has been removed from the list as well because because the issue
caused the hang has been fixed in Pakku.



submethod BUILD ( ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this be TWEAK?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can, it's just a habit to use BUILD since it gives more control over object construction. but in this case TWAEK makes more sense, since there is no arguments to .new anyway. I replaced BUILD with TWEAK.

"Blin::Module" : "lib/Blin/Module.rakumod",
"Blin::Processing" : "lib/Blin/Processing.rakumod",
"Blin::Tester::Zef" : "lib/Blin/Tester/Zef.rakumod",
"Blin::Tester::Pakku" : "lib/Blin/Tester/Pakku.rakumod"
},
"depends" : [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Pakku should be added as a dependency, right?

Copy link
Contributor Author

@hythm7 hythm7 Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it should, I removed it temporarily because Pakku was removed by mistake from the Ecosystem, so I removed it from list of dependencies temporarily until I get the time to add it back to the Ecosystem. I added Pakku now to META6.json file, but the build will fail.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just created a PR to re-add Pakku to the Ecosystem.

Copy link
Member

@AlexDaniel AlexDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Altai-man
Copy link
Member

Anything preventing merging this?

@Altai-man Altai-man merged commit 1438dbd into Raku:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants