-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pakku to Blin Testers #26
Conversation
show same bhavior when installed by Pakku or Zef. Fcntl has been removed from the list as well because because the issue caused the hang has been fixed in Pakku.
lib/Blin/Tester/Zef.rakumod
Outdated
|
||
|
||
|
||
submethod BUILD ( ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't this be TWEAK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can, it's just a habit to use BUILD
since it gives more control over object construction. but in this case TWAEK
makes more sense, since there is no arguments to .new
anyway. I replaced BUILD
with TWEAK
.
"Blin::Module" : "lib/Blin/Module.rakumod", | ||
"Blin::Processing" : "lib/Blin/Processing.rakumod", | ||
"Blin::Tester::Zef" : "lib/Blin/Tester/Zef.rakumod", | ||
"Blin::Tester::Pakku" : "lib/Blin/Tester/Pakku.rakumod" | ||
}, | ||
"depends" : [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Pakku should be added as a dependency, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it should, I removed it temporarily because Pakku was removed by mistake from the Ecosystem, so I removed it from list of dependencies temporarily until I get the time to add it back to the Ecosystem. I added Pakku now to META6.json
file, but the build will fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just created a PR to re-add Pakku
to the Ecosystem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Anything preventing merging this? |
Blin::Tester::Zef
andBlin::Tester::Pakku
classes..pm6
to.rakumod
--pm
option to switch between testersbin/blin.p6 --pm=zef
bin/blin.p6 --pm=pakku