Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Links #1542

Closed
rafaelschipiura opened this issue Sep 8, 2017 · 11 comments
Closed

Broken Links #1542

rafaelschipiura opened this issue Sep 8, 2017 · 11 comments

Comments

@rafaelschipiura
Copy link
Contributor

There's a ton of broken links in

https://docs.perl6.org/routine-operator.html

@molecules
Copy link
Contributor

Did someone fix them? If not, please share an example of one that is broken. None of those I tried seemed to have problems. I used Microsoft Edge and Mozilla Firefox on Windows 10.

@zakame
Copy link
Member

zakame commented Sep 8, 2017

@rafaelschipiura
Copy link
Contributor Author

rafaelschipiura commented Sep 8, 2017

For me tha5t page has a ton of error messages at the top complaining about the 404 links, so I thought it would be obvious it was broken.

Trying to be comprehensive, I opened all links and here are the ones that answer 404 for me:

https://docs.perl6.org/routine/.&
https://docs.perl6.org/routine/.*
https://docs.perl6.org/routine/.+
https://docs.perl6.org/routine/..$CIRCUMFLEX_ACCENT
https://docs.perl6.org/routine/.::
https://docs.perl6.org/routine/.:%3Cprefix%3E
https://docs.perl6.org/routine/.=
https://docs.perl6.org/routine/.$CIRCUMFLEX_ACCENT

Looking a bit more, I can fix the issue by adding ".html" at the end of the link. The problem seems to be links starting with "." but without ".html" at the end.

Sorry for taking so long for describing the bug, it was too late last night and I went to sleep.

@tisonkun
Copy link
Member

#1593 and #1592 report similar problems
I wonder where I can find the source code of pages below https://docs.perl6.org/routine/

@tisonkun
Copy link
Member

tisonkun commented Nov 9, 2017

The problem is url in htmlify.p6 is quite messy, and

https://docs.perl6.org/routine/.?
https://docs.perl6.org/routine/?

are both broken links, because ? handled badly.

Out strategy on url is replace-badchars-with-goodnames, that is very strange to me, why not directly escapeHTML?

@coke
Copy link
Collaborator

coke commented Nov 9, 2017

I believe badchars is also trying the solve the issue of the local file names, not just the URLs.

@coke
Copy link
Collaborator

coke commented Feb 20, 2018

Note that util/test-links.sh should help find all broken links, not just the ones on this page.

@denis-beurive
Copy link

denis-beurive commented Feb 20, 2018

Hello,

I noticed a similar issue :

From the page https://docs.perl6.org/routine.html, I clicked to the link below:

https://docs.perl6.org/routine/.*

The required page does not exit. Instead, I can read the following instructions :

The page you tried to reach cannot be found. If you got here by following a link on this site, please report it on our GitHub repository so we can fix it!

Thus I report the error.

Please note that I had opened an issue for this problem #1791.

Denis

@JJ
Copy link
Contributor

JJ commented Mar 5, 2018

There's also an invisible broken link in the first row, which shows a white column
screenshot from 2018-03-05 20 53 08
screenshot from 2018-03-05 20 55 02
This is related also to #561, although some of them might be due to htmlify.p6 problems, and thus related to #1823

@JJ
Copy link
Contributor

JJ commented Mar 30, 2018

And also #561, of course...

@JJ JJ added the TPF Grant label Mar 30, 2018
@JJ JJ removed the JJ TPF Grant label May 14, 2018
@MorayJ
Copy link
Contributor

MorayJ commented Aug 10, 2018

I'm not closing this as I'm not sure of the history and the links (to the wider issue, rather than html links), but i've just run through all the links on the page and they are all working. This report ought to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants