Add a test for invalid Int:D families for IO::Socket::INET.new #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My first attempt at rakudo/rakudo#4047 typed families as ProtocolFamily(Int:D). This passed Roast despite making the method accept invalid Int:D values.
Kaiepi
force-pushed
the
io-socket-inet-enums
branch
from
cd31d9e
to
be962b7
Compare
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first attempt at rakudo/rakudo#4047 typed
families as
ProtocolFamily(Int:D). This passed Roast despite making themethod accept invalid
Int:Dvalues.