Mark a couple archetype methods as inline
#102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunkIter calls `archetype.entities()` and `archetype.len()`. By marking them `inline`, the outer loop of query iteration avoids two function calls to these trivial methods (and the register spills those cause). This speeds up the iterate_100k benchmark by 23%. That feels unreasonably high since it doesn't affect the innermost loop, but even if this benefit is illusory the machine code is tighter so this is a win.
|
Even though this shouldn't be helping iterate_100k very much, it is theoretically useful where there is high archetype fragmentation, because these archetype methods will get called much more often. |
|
I actually don't see any change in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChunkIter calls
archetype.entities()andarchetype.len().By marking them
inline, the outer loop of query iterationavoids two function calls to these trivial methods (and the
register spills those cause).
This speeds up the iterate_100k benchmark by 23%. That feels
unreasonably high since it doesn't affect the innermost loop, but
even if this benefit is illusory the machine code is tighter so
this is a win.