Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty Print String Limitations #6

Closed
jredfox opened this issue Mar 7, 2019 · 3 comments
Closed

Pretty Print String Limitations #6

jredfox opened this issue Mar 7, 2019 · 3 comments

Comments

@jredfox
Copy link

jredfox commented Mar 7, 2019

Pretty print in JSONFormatter doesn't allow for printing large json objects to a file only the indexed amount of chars which in unicode form most common json type is around 500 million chars. Sounds like alot but, actually isn't for a decent size json file.

Yes you can still support string/reader but, there should be a method inside where it only accepts Writer and will properly write the whole json object/array to the file the first time

@RalleYTN
Copy link
Owner

Will add the methods

  • JSONFormatter#format(JSONObject,Writer)
  • JSONFormatter#format(JSONArray,Writer)
    in the next release

@jredfox
Copy link
Author

jredfox commented Jan 26, 2020

this is still next fixed can you please add this feature?

@RalleYTN
Copy link
Owner

this is still next fixed can you please add this feature?

Issue fixed with newest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants