Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Closing Rare doesn't exit threads #229

Open
rjbprime opened this issue Jul 16, 2022 · 2 comments
Open

[BUG] Closing Rare doesn't exit threads #229

rjbprime opened this issue Jul 16, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@rjbprime
Copy link

Describe the bug
When closing Rare after a download, threads are still running, and must be terminated with task manager.

To Reproduce
Steps to reproduce the behavior:

  1. Download a game.
  2. Either let it complete or cancel it.
  3. Right click on tray icon and click exit.
  4. See error

Expected behavior
Threads exit immediately.

Screenshots
Not really applicable,

Desktop (please complete the following information):

  • OS: Windows 10
  • Version: 1.8.9
  • Installation: MSI
  • Python 3.10

Additional context
Not a major issue, but if needing to delete a folder/file after canceled download, whilst one of the threads are actively using it, windows fails to delete the file, saying it is in use.

Error message

@rjbprime rjbprime added the bug Something isn't working label Jul 16, 2022
@Dummerle
Copy link
Collaborator

Thanks for reporting. I will try to reproduce the error. Did you have games in queue, which started? And the download was completed? Spontaneous I have no idea, why this happens.

@rjbprime
Copy link
Author

I did, but then I cancelled them before they started. The one that had started was cancelled after the others were cancelled, so I would think it would close all open threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants