Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom NLG class from module string #4953

Closed
pheel opened this issue Dec 11, 2019 · 1 comment
Closed

Custom NLG class from module string #4953

pheel opened this issue Dec 11, 2019 · 1 comment
Labels
type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@pheel
Copy link
Contributor

pheel commented Dec 11, 2019

Description of Problem:
Rasa supports module strings in configuration files, which makes it easy to develop custom file importers, channels, tracker stores, policies, NLU components, etc. One aspect that escapes this customization pattern is the Natural Language Generator class. This could be useful for many reasons, including specifying one's own NLG request schema.

Overview of the Solution:
I propose to use the existing type kwarg of rasa.utils.endpoints.EndpointConfig to specify a module string. Resolved modules would then be initialized with i) the endpoint config (including url and other kwargs) and ii) the domain. If module does not resolve, fallback to the current built-ins.

@pheel pheel added the type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR label Dec 11, 2019
@tmbo
Copy link
Member

tmbo commented Dec 11, 2019

Fixed as part of #4801

@tmbo tmbo closed this as completed Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

2 participants