Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified external class instantiation #4801

Merged
merged 13 commits into from
Dec 11, 2019
Merged

Unified external class instantiation #4801

merged 13 commits into from
Dec 11, 2019

Conversation

tmbo
Copy link
Member

@tmbo tmbo commented Nov 20, 2019

Proposed changes:

  • allow external creation of natural language interpreter
  • allow external creation of natural language generator
  • unified naming of broker classes
  • unified creation of referenced type s in the EndpointConfig
  • unified create API of LockStore, EventBroker, NaturalLanguageInterpreter, NaturalLanguageGenerator

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@tmbo tmbo requested a review from federicotdn December 4, 2019 13:33
federicotdn
federicotdn reviewed Dec 11, 2019
View reviewed changes
Copy link
Contributor

@federicotdn federicotdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments!

changelog/4801.improvement.rst Outdated Show resolved Hide resolved
rasa/core/brokers/broker.py Outdated Show resolved Hide resolved
rasa/core/brokers/event_channel.py Outdated Show resolved Hide resolved
rasa/core/brokers/file_producer.py Outdated Show resolved Hide resolved
rasa/core/brokers/kafka.py Outdated Show resolved Hide resolved
rasa/core/brokers/sql.py Outdated Show resolved Hide resolved
rasa/core/brokers/sql.py Outdated Show resolved Hide resolved
rasa/core/tracker_store.py Outdated Show resolved Hide resolved
rasa/core/lock_store.py Outdated Show resolved Hide resolved
rasa/core/tracker_store.py Outdated Show resolved Hide resolved
@tmbo
Copy link
Member Author

tmbo commented Dec 11, 2019

@federicotdn addressed your comments, would be great if you can take another look.

federicotdn
federicotdn approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@federicotdn federicotdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add 👍

@tmbo tmbo merged commit 03da437 into master Dec 11, 2019
@tmbo tmbo deleted the class-based-nlg branch December 11, 2019 20:14
This was referenced Dec 11, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@federicotdn federicotdn federicotdn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmbo @federicotdn