Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting custom nlg class in endpoints #4954

Closed
wants to merge 1 commit into from
Closed

allow setting custom nlg class in endpoints #4954

wants to merge 1 commit into from

Conversation

pheel
Copy link
Contributor

@pheel pheel commented Dec 11, 2019

Proposed changes:
Answers #4953. This feature allows a custom module string to be set under endpoints.nlg.type.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@claassistantio
Copy link

claassistantio commented Dec 11, 2019

CLA assistant check
All committers have signed the CLA.

@tmbo
Copy link
Member

tmbo commented Dec 11, 2019

Thanks a lot for your contribution - it’s a bit unfortunate in timing because we just fixed this in #4801 😅 let me know if there is still an issue on master with this 👍

@tmbo tmbo closed this Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants