Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type annotations #1642

Merged
merged 11 commits into from
Jan 24, 2019
Merged

Type annotations #1642

merged 11 commits into from
Jan 24, 2019

Conversation

tmbo
Copy link
Member

@tmbo tmbo commented Jan 23, 2019 •
edited
Loading

Proposed changes:

  • convert python 2 type annotations to python 3

Status (please check what you already did):

  • made PR ready for code review

@tmbo tmbo changed the title WIP Type annotations Type annotations Jan 24, 2019
@tmbo tmbo requested a review from ricwo January 24, 2019 09:40
ricwo
ricwo approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@ricwo ricwo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

I marked the obvious Optional[] arguments where the code checks for is None or is not None

rasa_nlu/config.py Outdated Show resolved Hide resolved
rasa_nlu/data_router.py Outdated Show resolved Hide resolved
rasa_nlu/classifiers/sklearn_intent_classifier.py Outdated Show resolved Hide resolved
rasa_nlu/components.py Outdated Show resolved Hide resolved
rasa_nlu/extractors/crf_entity_extractor.py Outdated Show resolved Hide resolved
rasa_nlu/model.py Outdated Show resolved Hide resolved
ricwo and others added 2 commits January 24, 2019 11:12
@ricwo @tmbo
Update rasa_nlu/config.py
c99e936 
Co-Authored-By: tmbo <tom@rasa.com>
@ricwo @tmbo
Apply suggestions from code review
636d9dd 
Co-Authored-By: tmbo <tom@rasa.com>
@tmbo
Copy link
Member Author

tmbo commented Jan 24, 2019

Thanks a lot 🚀

@codeclimate
Copy link

codeclimate bot commented Jan 24, 2019

Code Climate has analyzed commit 6cf9ce3 and detected 12 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 5
Style 7

Note: there is 1 critical issue.

View more on Code Climate.

@tmbo tmbo merged commit 62bc21f into master Jan 24, 2019
@tmbo tmbo deleted the type-annotations branch January 24, 2019 12:13
@tmbo tmbo mentioned this pull request Jan 24, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricwo ricwo ricwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmbo @ricwo