Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projects page table of projects #317

Merged
merged 26 commits into from
Jan 6, 2023
Merged

Projects page table of projects #317

merged 26 commits into from
Jan 6, 2023

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Jan 5, 2023 •
edited by IzzySmillie
Loading

  • Styling for 'Last updated' has been done but commented out for now as was using dummy data
  • Delete action being addressed in another ticket

Screenshots
Screenshot 2023-01-06 at 12 45 55
Screenshot 2023-01-06 at 12 46 10

Screenshot 2023-01-06 at 11 41 06

With Last updated commented out:
Screenshot 2023-01-06 at 12 50 18

@create-issue-branch create-issue-branch bot temporarily deployed to previews/issues/309-Projects_page_table_of_projects January 5, 2023 10:33 Inactive
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/309-Projects_page_table_of_projects January 5, 2023 12:46 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/309-Projects_page_table_of_projects January 5, 2023 14:32 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/309-Projects_page_table_of_projects January 5, 2023 17:06 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/309-Projects_page_table_of_projects January 5, 2023 17:42 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/309-Projects_page_table_of_projects January 5, 2023 18:00 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/309-Projects_page_table_of_projects January 6, 2023 09:38 — with GitHub Actions Inactive
@IzzySmillie IzzySmillie temporarily deployed to previews/issues/309-Projects_page_table_of_projects January 6, 2023 09:40 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

@IzzySmillie IzzySmillie self-assigned this Jan 6, 2023
@IzzySmillie IzzySmillie temporarily deployed to previews/issues/309-Projects_page_table_of_projects January 6, 2023 12:47 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

loiswells97
loiswells97 reviewed Jan 6, 2023
View reviewed changes
Copy link
Contributor

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few questions/comments

src/components/ProjectIndex/ProjectIndex.js Outdated Show resolved Hide resolved
src/components/ProjectIndex/ProjectIndex.js Outdated Show resolved Hide resolved
src/components/ProjectListTable/ProjectListTable.js Outdated Show resolved Hide resolved
@IzzySmillie IzzySmillie temporarily deployed to previews/issues/309-Projects_page_table_of_projects January 6, 2023 14:57 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/309-Projects_page_table_of_projects January 6, 2023 15:03 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/309-Projects_page_table_of_projects January 6, 2023 15:12 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/309-Projects_page_table_of_projects January 6, 2023 15:18 — with GitHub Actions Inactive
loiswells97
loiswells97 reviewed Jan 6, 2023
View reviewed changes
Copy link
Contributor

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny question/comment, but lgtm apart from that :)

src/i18n.js Outdated Show resolved Hide resolved
@IzzySmillie IzzySmillie temporarily deployed to previews/issues/309-Projects_page_table_of_projects January 6, 2023 15:39 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

loiswells97
loiswells97 approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Izzy 👍

@IzzySmillie IzzySmillie merged commit 6e18eff into main Jan 6, 2023
@IzzySmillie IzzySmillie deleted the issues/309-Projects_page_table_of_projects branch January 6, 2023 16:07
patch0 added a commit that referenced this pull request Jan 17, 2023
@patch0
Release v0.11.0
446b599 
 ## Added

- Styling of the projects list (#317)
- Ability to collapse and expand the left hand file pane (#316)
- Plausible event tracking for left hand file pane (#325)
- Last updated field added to the projects table (#319)
- Message for empty state on projects (#327)
- Rename project action on project index page (#324)
- Context menu for project index page actions on mobile (#324)
- Danger button styling (#330)

 ## Changed

- Change port number to fix 'no consent token' error (#326)
- Long file names truncated rather than scrolling in left hand file pane (#316, #337)
- Tab scrollbars only appear when necessary (#331)
- Added merge=union gitattribute for this file (#339)

 ## Fixed

- Make sure button text is always centered (#328)
- Make theme and font size persist across all pages of the app (#329)
- Make dismissing the Beta banner persist across all pages of the app (#329)
- Touch area of icon-only buttons (#330, #336)
- Delete project action on project index page (#330)
- Refactored project list loading to allow loading states to be shown (#330)
- Removed unneeded scrollbars on the editor and output panels (#331)
- Make Your projects page background extend below the fold (#334)
@patch0 patch0 mentioned this pull request Jan 17, 2023
Merged
patch0 added a commit that referenced this pull request Jan 17, 2023
@patch0
Release v0.11.0 (#340)
66b38aa 
## Added

- Styling of the projects list (#317)
- Ability to collapse and expand the left hand file pane (#316)
- Plausible event tracking for left hand file pane (#325)
- Last updated field added to the projects table (#319)
- Message for empty state on projects (#327)
- Rename project action on project index page (#324)
- Context menu for project index page actions on mobile (#324)
- Danger button styling (#330)

## Changed

- Change port number to fix 'no consent token' error (#326)
- Long file names truncated rather than scrolling in left hand file pane
(#316, #337)
- Tab scrollbars only appear when necessary (#331)
- Added merge=union gitattribute for this file (#339)

## Fixed

- Make sure button text is always centered (#328)
- Make theme and font size persist across all pages of the app (#329)
- Make dismissing the Beta banner persist across all pages of the app
(#329)
- Touch area of icon-only buttons (#330, #336)
- Delete project action on project index page (#330)
- Refactored project list loading to allow loading states to be shown
(#330)
- Removed unneeded scrollbars on the editor and output panels (#331)
- Make Your projects page background extend below the fold (#334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IzzySmillie IzzySmillie IzzySmillie left review comments

@loiswells97 loiswells97 loiswells97 approved these changes

Assignees

@IzzySmillie IzzySmillie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Projects page table of projects
2 participants
@IzzySmillie @loiswells97