Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings persistence across pages #329

Merged
merged 11 commits into from
Jan 16, 2023

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Jan 11, 2023

What's Changed?

  • Fixed settings persistence across all pages by giving the related cookies a path of /
  • Fixed persistence of dismissing the beta banner

closes #313

@create-issue-branch create-issue-branch bot temporarily deployed to previews/issues/313-Settings_persistence_across_pages January 11, 2023 17:19 Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/313-Settings_persistence_across_pages January 11, 2023 17:21 — with GitHub Actions Inactive
@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@loiswells97 loiswells97 marked this pull request as ready for review January 11, 2023 17:25
Copy link
Contributor

@IzzySmillie IzzySmillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't working for me. I'm unable to select the other theme or font sizes.

I tested removing the path and was able to select them again?

@loiswells97 loiswells97 temporarily deployed to previews/issues/313-Settings_persistence_across_pages January 12, 2023 11:38 — with GitHub Actions Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/313-Settings_persistence_across_pages January 12, 2023 11:44 — with GitHub Actions Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/313-Settings_persistence_across_pages January 12, 2023 11:59 — with GitHub Actions Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/313-Settings_persistence_across_pages January 12, 2023 12:12 — with GitHub Actions Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/313-Settings_persistence_across_pages January 16, 2023 11:56 — with GitHub Actions Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/313-Settings_persistence_across_pages January 16, 2023 14:09 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/313-Settings_persistence_across_pages January 16, 2023 14:24 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/313-Settings_persistence_across_pages January 16, 2023 14:41 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/313-Settings_persistence_across_pages January 16, 2023 15:08 — with GitHub Actions Inactive
@github-actions
Copy link

Copy link
Contributor

@patch0 patch0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patch0 patch0 temporarily deployed to previews/issues/313-Settings_persistence_across_pages January 16, 2023 16:10 — with GitHub Actions Inactive
@github-actions
Copy link

@patch0 patch0 enabled auto-merge (squash) January 16, 2023 16:17
@patch0 patch0 temporarily deployed to previews/issues/313-Settings_persistence_across_pages January 16, 2023 16:18 — with GitHub Actions Inactive
@github-actions
Copy link

@patch0 patch0 merged commit 438786d into main Jan 16, 2023
@patch0 patch0 deleted the issues/313-Settings_persistence_across_pages branch January 16, 2023 16:21
patch0 added a commit that referenced this pull request Jan 17, 2023
 ## Added

- Styling of the projects list (#317)
- Ability to collapse and expand the left hand file pane (#316)
- Plausible event tracking for left hand file pane (#325)
- Last updated field added to the projects table (#319)
- Message for empty state on projects (#327)
- Rename project action on project index page (#324)
- Context menu for project index page actions on mobile (#324)
- Danger button styling (#330)

 ## Changed

- Change port number to fix 'no consent token' error (#326)
- Long file names truncated rather than scrolling in left hand file pane (#316, #337)
- Tab scrollbars only appear when necessary (#331)
- Added merge=union gitattribute for this file (#339)

 ## Fixed

- Make sure button text is always centered (#328)
- Make theme and font size persist across all pages of the app (#329)
- Make dismissing the Beta banner persist across all pages of the app (#329)
- Touch area of icon-only buttons (#330, #336)
- Delete project action on project index page (#330)
- Refactored project list loading to allow loading states to be shown (#330)
- Removed unneeded scrollbars on the editor and output panels (#331)
- Make Your projects page background extend below the fold (#334)
@patch0 patch0 mentioned this pull request Jan 17, 2023
patch0 added a commit that referenced this pull request Jan 17, 2023
## Added

- Styling of the projects list (#317)
- Ability to collapse and expand the left hand file pane (#316)
- Plausible event tracking for left hand file pane (#325)
- Last updated field added to the projects table (#319)
- Message for empty state on projects (#327)
- Rename project action on project index page (#324)
- Context menu for project index page actions on mobile (#324)
- Danger button styling (#330)

## Changed

- Change port number to fix 'no consent token' error (#326)
- Long file names truncated rather than scrolling in left hand file pane
(#316, #337)
- Tab scrollbars only appear when necessary (#331)
- Added merge=union gitattribute for this file (#339)

## Fixed

- Make sure button text is always centered (#328)
- Make theme and font size persist across all pages of the app (#329)
- Make dismissing the Beta banner persist across all pages of the app
(#329)
- Touch area of icon-only buttons (#330, #336)
- Delete project action on project index page (#330)
- Refactored project list loading to allow loading states to be shown
(#330)
- Removed unneeded scrollbars on the editor and output panels (#331)
- Make Your projects page background extend below the fold (#334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings persistence across pages
3 participants